We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This productivity calculation seems to show up 3 times in the code, and I've been trying to find the error, but I can't :(
However, while trying to understand all the code, it seems to me that some steps seem redundant. Example spot of the code can be found here: https://github.com/LiskHQ/lisk/blob/0d6c94768f212a23687fa58d8faae4782ede3b37/modules/accounts.js#L538
Now this may be for validation, but the line: parseFloat(Math.floor(percent * 100) / 100).toFixed(2)
I would think could be written as: Math.floor(percent * 100) / 100) or parseFloat((percent * 100) / 100).toFixed(2)
Not a big issue or anything, but trying to understand and help if I can :)
The text was updated successfully, but these errors were encountered:
f30d1c5
Merge pull request #107 from LiskHQ/103-socketcluster-upgrade
87a4f05
Bump socketcluster and socketcluster-client versions - Closes #103
karmacoma
No branches or pull requests
This productivity calculation seems to show up 3 times in the code, and I've been trying to find the error, but I can't :(
However, while trying to understand all the code, it seems to me that some steps seem redundant. Example spot of the code can be found here:
https://github.com/LiskHQ/lisk/blob/0d6c94768f212a23687fa58d8faae4782ede3b37/modules/accounts.js#L538
Now this may be for validation, but the line:
parseFloat(Math.floor(percent * 100) / 100).toFixed(2)
I would think could be written as:
Math.floor(percent * 100) / 100)
or
parseFloat((percent * 100) / 100).toFixed(2)
Not a big issue or anything, but trying to understand and help if I can :)
The text was updated successfully, but these errors were encountered: