Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update block version to 1 #2199

Closed
MaciejBaj opened this Issue Jul 4, 2018 · 0 comments

Comments

Projects
2 participants
@MaciejBaj
Copy link
Member

MaciejBaj commented Jul 4, 2018

While 0.9.16 and 1.0. versions are not compatible with each other (peers cannot connect) - there is still possible to keep the 0.9.16 chain running. Because there is nothing at stake - probably most of the delegates would like to keep forging on that chain, and because of such a possibility - it's reasonable to assume that 0.9.16 chain will be the longer one. There can be some issues if somebody decide to migrate 0.9.16 chain later (after migration height) and announce it to rest of the peers that are already running 1.0.0 chain. To ensure smooth migration and prevent situation described above from happening - would be nice to bump block's property version (which is taken into account when generating the signature).

@MaciejBaj MaciejBaj added this to the Version 1.0.0-rc.2 milestone Jul 10, 2018

@MaciejBaj MaciejBaj added this to Open Issues in Version 1.0.0 via automation Jul 30, 2018

MaciejBaj added a commit that referenced this issue Jul 30, 2018

Merge pull request #2262 from LiskHQ/2199_block-version
Refacor isValid function in logic/block_version - Closes #2199

@MaciejBaj MaciejBaj closed this in 30cf495 Aug 2, 2018

Version 1.0.0 automation moved this from Open Issues to Closed Issues Aug 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.