Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase default number of transactions from public API to 25 #2293

Closed
willclarktech opened this issue Aug 7, 2018 · 4 comments
Closed

Increase default number of transactions from public API to 25 #2293

willclarktech opened this issue Aug 7, 2018 · 4 comments

Comments

@willclarktech
Copy link
Contributor

Expected behavior

Accessing the transactions endpoint should give all transactions in a block by default. Especially if the blockId query is used.

Actual behavior

The default is 10.

Steps to reproduce

Access the transactions endpoint and specify the block ID of a full block.

Which version(s) does this affect? (Environment, OS, etc...)

1.0.0+

@nazarhussain
Copy link
Contributor

You can already do it by passing limit param to the API. I don't think setting limit conditionally based on different parameters is a good idea.

@MaciejBaj MaciejBaj added the api label Aug 9, 2018
@MaciejBaj
Copy link
Contributor

@willclarktech do you feel like passing limit as @nazarhussain suggests covers the issue? Setting the limit from 10 to 25 doesn't really solve anything, it would return nice results only for full blocks.

@willclarktech
Copy link
Contributor Author

@MaciejBaj This was an issue created after feedback from an exchange (and I told them of course about the limit parameter). I don't have a strong opinion about the best solution here.

@MaciejBaj
Copy link
Contributor

I am not finding strong arguments for implementing the changes. Closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants