Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Makefile #2400

Closed
Nazgolze opened this issue Sep 17, 2018 · 2 comments · Fixed by #2545
Closed

Makefile #2400

Nazgolze opened this issue Sep 17, 2018 · 2 comments · Fixed by #2545
Assignees
@Nazgolze
Labels
framework
Milestone
Version 1.4.0

Comments

@Nazgolze
Copy link
Contributor

Create Makefile that supplants lisk-build
@Nazgolze
Copy link
Contributor Author

This Makefile will build a binary release like lisk-build currently does, building the dependencies as well (libreadline7, jq, postgres, etc)

@Nazgolze Nazgolze mentioned this issue Sep 17, 2018
Closed
@fchavant fchavant mentioned this issue Sep 17, 2018
Closed
@MaciejBaj MaciejBaj added the *hard label Oct 3, 2018
@MaciejBaj MaciejBaj added this to the Version 1.4.0 milestone Oct 25, 2018
@fchavant
Copy link
Contributor

fchavant commented Nov 13, 2018 •
edited
Loading

In a first step we can migrate the current build.sh from LiskHQ/lisk-build with minimal changes.
The only issue is grunt release being a prerequisite (needs Node.JS which we get only later in build.sh); it only executes a few shell commands however and so could be replaced by a Makefile.

@MaciejBaj @Nazgolze does that sound reasonable to you?

@fchavant fchavant mentioned this issue Nov 13, 2018
Merged
@MaciejBaj MaciejBaj modified the milestone: Version 1.4.0 Nov 21, 2018
MaciejBaj added a commit that referenced this issue Nov 22, 2018
@MaciejBaj
Merge pull request #2545 from LiskHQ/2400-build-makefile-part1
3a32e7d 
Move LiskHQ/lisk-build into LiskHQ/lisk and introduce basic Makefile - Closes #2400
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Nazgolze Nazgolze

Labels
framework
Projects
None yet
Milestone
Version 1.4.0
5 participants
@Nazgolze @diego-G @Tschakki @MaciejBaj @fchavant