Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default delegate sorting to rank:asc - Closes #2138 #2153

Merged
merged 1 commit into from Jun 26, 2018

Conversation

Tschakki
Copy link
Member

What was the problem?

Default sorting for the list of delegates in Lisk Core API was rank:desc

How did I fix it?

Changed it to rank:asc, as this is the behaviour which is expected as default.

How to test it?

Make GET /api/delegates request without specifying the sort parameter.
Response should be sorted by rank in ascending order.

Review checklist

Copy link
Contributor

@nazarhussain nazarhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am good with change. Only concern is this may break any third party tool which is relaying on default sorting of this endpoint. Should we include it in minor release? @MaciejBaj

@MaciejBaj
Copy link
Contributor

Changing a default parameter doesn't break the API in my opinion. We can proceed with this PR.

@MaciejBaj MaciejBaj merged commit baac15c into 1.1.0 Jun 26, 2018
@MaciejBaj MaciejBaj deleted the 2138-sort-delegates-rank-asc-by-default branch June 26, 2018 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants