Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add block version exception for devnet-rc2 branch - Closes #2258 #2257

Merged
merged 2 commits into from Jul 27, 2018

Conversation

nazarhussain
Copy link
Contributor

@nazarhussain nazarhussain commented Jul 26, 2018

What was the problem?

Migration is being tested from round 11 with the version being built out of devnet-development branch. To validate the block version properly the entry in exceptions needs to be added.

How did I fix it?

Block version 1 range is added in exceptions.

How to test it?

Check if blocks after the height 1111 are having version 1 and are getting accepted.

Review checklist

@MaciejBaj
Copy link
Contributor

22:00:48 �[92m �[0m�[32m 108 passing�[0m�[90m (5s)�[0m
22:00:48 �[31m  1 failing�[0m
22:00:48 
22:00:48 �[0m  1) blocks/verify
22:00:48        __private.verifyVersion
22:00:48          when there are no exceptions for block versions
22:00:48            when block height provided
22:00:48              should return error when block version = 0:
22:00:48 �[0m�[31m     AssertionError: expected undefined to equal 'Invalid block version'�[0m�[90m
22:00:48     at Context.it (test/unit/modules/blocks/verify.js:474:48)
22:00:48     at Test.Runnable.run (node_modules/co-mocha/lib/co-mocha.js:42:16)
22:00:48   
22:00:48 �[0m
22:00:48 

Copy link
Contributor

@MaciejBaj MaciejBaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocks/verify: __private.verifyVersion failing

@MaciejBaj MaciejBaj changed the title Add block version exception for devnet-rc2 branch Add block version exception for devnet-rc2 branch - Closes #2258 Jul 27, 2018
@MaciejBaj MaciejBaj merged commit 34d410c into devnet-development Jul 27, 2018
@MaciejBaj MaciejBaj deleted the nh-block-version-exception branch July 27, 2018 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants