This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Add from/to timestamp filter to get blocks endpoint - Closes #2391 #2472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazarhussain
suggested changes
Oct 16, 2018
| @@ -106,6 +106,16 @@ __private.list = function(filter, cb) { | |||
| params.height = filter.height; | |||
| } | |||
|
|
|||
| if (filter.fromTimestamp >= 0) { | |||
There was a problem hiding this comment.
In swagger we say 0 is the valid value. Should not we simplify it on API level to disallow zero as param value?
There was a problem hiding this comment.
The idea is to keep 0 as an allowed value. However, there was a mistake in the control of toTimestamp that I've caught thanks to this comment. @nazarhussain could you check it again? I hope now it's easier to understand.
modules/blocks/api.js
Outdated
| params.fromTimestamp = filter.fromTimestamp; | ||
| } | ||
|
|
||
| if (filter.toTimestamp >= 0) { |
ManuGowda
suggested changes
Oct 16, 2018
test/functional/http/get/blocks.js
Outdated
| @@ -112,6 +113,72 @@ describe('GET /blocks', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('fromTimestamp', () => { | |||
| it('using too small fromTimestamp should fail', () => { | |||
There was a problem hiding this comment.
using invalid timestamp should fail?
test/functional/http/get/blocks.js
Outdated
| }); | ||
|
|
||
| describe('toTimestamp', () => { | ||
| it('using too small toTimestamp should fail', () => { |
nazarhussain
approved these changes
Oct 16, 2018
MaciejBaj
approved these changes
Oct 17, 2018
ManuGowda
approved these changes
Oct 18, 2018
4miners
approved these changes
Oct 18, 2018
…o_timestamp_filter_get_blocks
shuse2
approved these changes
Oct 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test it?
mocha test/functional/http/get/blocks.jsReview checklist