This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Move LiskHQ/lisk-build into LiskHQ/lisk and introduce basic Makefile - Closes #2400 #2545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fchavant
force-pushed
the
2400-build-makefile-part1
branch
2 times, most recently
from
12c262b
to
71d204a
Compare
nazarhussain
suggested changes
Nov 14, 2018
fchavant
force-pushed
the
2400-build-makefile-part1
branch
from
e557be8
to
6003724
Compare
fchavant
force-pushed
the
2400-build-makefile-part1
branch
from
be91a76
to
99cb916
Compare
MaciejBaj
previously approved these changes
Nov 20, 2018
fchavant
force-pushed
the
2400-build-makefile-part1
branch
from
8b9aa48
to
e1a78d7
Compare
Nazgolze
suggested changes
Nov 21, 2018
Nazgolze
previously approved these changes
Nov 22, 2018
nazarhussain
previously requested changes
Nov 22, 2018
To use 'npm pack' we now: - download Node.JS first, - unpack and use it to call 'npm pack' and - continue with the build as before
fchavant
force-pushed
the
2400-build-makefile-part1
branch
from
e61b976
to
c7e62cf
Compare
|
Together with @fchavant @Nazgolze @nazarhussain @shuse2 we decided that:
|
nazarhussain
approved these changes
Nov 22, 2018
MaciejBaj
reviewed
Nov 22, 2018
| LISK_SCRIPTS_FILE="$LISK_SCRIPTS_DIR.tar.gz" | ||
| LISK_SCRIPTS_URL="https://github.com/LiskHQ/lisk-scripts/archive/v$LISK_SCRIPTS_VERSION.tar.gz" | ||
|
|
||
| NODE_VERSION="8.13.0" |
There was a problem hiding this comment.
I will create a PR to update the node version to 8.13.0 for the sources as well.
MaciejBaj
approved these changes
Nov 22, 2018
This was referenced Mar 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
The build script was separated from the code altough it's tightly coupled with its dependencies.
How did I fix it?
Moved
build.shfrom LiskHQ/lisk-build into thebuildsubdirectory.How to test it?
Follow the instructions in
build/README.md; it boils down to using Ubuntu 16.04, installing the dependencies and runningmake LISK_NET=<test|main>.Review checklist