Apply eslint-rule eqeqeq - Related to #1597 #2562

diego-G · 2018-11-21T11:54:07Z

Review checklist

The PR is related to Enable pending eslint rules #1597
All new code is covered with unit tests
All new code was formatted with Prettier
Linting passes
Tests pass
Commit messages follow the commit guidelines
Documentation has been added/updated

modules/dapps.js

api/ws/rpc/connect.js

api/ws/workers/middlewares/handshake.js

MaciejBaj

https://github.com/LiskHQ/lisk/pull/2562/files#r235910453

api/ws/rpc/connect.js

api/ws/workers/middlewares/handshake.js

yatki

I'm just trying to use 3rd parties as less as possible.

helpers/z_schema.js

helpers/http_api.js

helpers/z_schema.js

test/common/helpers/api.js

Co-Authored-By: diego-G <diego@lightcurve.io>

diego-G added the 👁️ pending review label Nov 21, 2018

diego-G self-assigned this Nov 21, 2018

diego-G requested review from ManuGowda, 4miners and yatki November 21, 2018 11:54

ManuGowda suggested changes Nov 21, 2018

View reviewed changes

modules/dapps.js Show resolved Hide resolved

ManuGowda previously approved these changes Nov 21, 2018

View reviewed changes

diego-G changed the title ~~Apply eslint-rule eqeqeq - #1597~~ Apply eslint-rule eqeqeq - Related to #1597 Nov 22, 2018

ManuGowda mentioned this pull request Nov 22, 2018

Enable pending eslint rules #1597

Closed

26 tasks

MaciejBaj suggested changes Nov 22, 2018

View reviewed changes

api/ws/rpc/connect.js Show resolved Hide resolved

diego-G dismissed ManuGowda’s stale review via 5ce7cd5 November 22, 2018 13:23

yatki previously approved these changes Nov 22, 2018

View reviewed changes

MaciejBaj suggested changes Nov 22, 2018

View reviewed changes

api/ws/rpc/connect.js Outdated Show resolved Hide resolved

diego-G added 🏗️ in progress and removed 👁️ pending review labels Nov 22, 2018

diego-G dismissed yatki’s stale review via 133deda November 23, 2018 10:08

diego-G force-pushed the 1597-apply-eslint-rule-eqeqeq branch 3 times, most recently from 182bc0d to e8c732e Compare November 23, 2018 10:24

diego-G requested review from ManuGowda, yatki and MaciejBaj and removed request for 4miners November 23, 2018 10:32

diego-G added 👁️ pending review and removed 🏗️ in progress labels Nov 23, 2018

MaciejBaj reviewed Nov 23, 2018

View reviewed changes

api/ws/workers/middlewares/handshake.js Outdated Show resolved Hide resolved

MaciejBaj suggested changes Nov 23, 2018

View reviewed changes

diego-G force-pushed the 1597-apply-eslint-rule-eqeqeq branch from e8c732e to b04a59a Compare November 23, 2018 11:35

ManuGowda suggested changes Nov 23, 2018

View reviewed changes

api/ws/rpc/connect.js Outdated Show resolved Hide resolved

api/ws/rpc/connect.js Outdated Show resolved Hide resolved

MaciejBaj reviewed Nov 23, 2018

View reviewed changes

api/ws/workers/middlewares/handshake.js Outdated Show resolved Hide resolved

diego-G added 👁️ pending review and removed 🏗️ in progress labels Nov 26, 2018

diego-G requested a review from nazarhussain November 27, 2018 13:35

yatki suggested changes Nov 27, 2018

View reviewed changes

helpers/z_schema.js Outdated Show resolved Hide resolved

diego-G added 3 commits November 27, 2018 14:40

Apply eslint-rule eqeqeq

9fb9502

Fix comments related to eslint-rule eqeqeq

9d05050

Prefer check as strings in parsedInt custom schema

0bb81c1

diego-G force-pushed the 1597-apply-eslint-rule-eqeqeq branch from 2193636 to 0bb81c1 Compare November 27, 2018 13:43

diego-G requested a review from yatki November 27, 2018 13:48

yatki previously approved these changes Nov 27, 2018

View reviewed changes

MaciejBaj suggested changes Nov 27, 2018

View reviewed changes

helpers/z_schema.js Outdated Show resolved Hide resolved

helpers/http_api.js Outdated Show resolved Hide resolved

helpers/z_schema.js Outdated Show resolved Hide resolved

ManuGowda previously approved these changes Nov 27, 2018

View reviewed changes

MaciejBaj reviewed Nov 27, 2018

View reviewed changes

helpers/z_schema.js Outdated Show resolved Hide resolved

MaciejBaj reviewed Nov 27, 2018

View reviewed changes

helpers/z_schema.js Outdated Show resolved Hide resolved

Prefer native Array.isArray than lodash method

6129dab

diego-G dismissed stale reviews from ManuGowda and yatki via 6129dab November 28, 2018 09:10

diego-G requested review from yatki, ManuGowda and MaciejBaj November 28, 2018 09:11

yatki previously approved these changes Nov 28, 2018

View reviewed changes

MaciejBaj reviewed Nov 28, 2018

View reviewed changes

test/common/helpers/api.js Outdated Show resolved Hide resolved

Fix condition in test/common/helpers/api.js

df9a2fc

Co-Authored-By: diego-G <diego@lightcurve.io>

diego-G dismissed stale reviews from yatki via df9a2fc November 28, 2018 10:08

MaciejBaj approved these changes Nov 28, 2018

View reviewed changes

MaciejBaj added ✅ ready and removed 👁️ pending review labels Nov 28, 2018

MaciejBaj merged commit 0abd0b4 into development Nov 28, 2018

MaciejBaj deleted the 1597-apply-eslint-rule-eqeqeq branch November 28, 2018 16:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Apply eslint-rule eqeqeq - Related to #1597 #2562

Apply eslint-rule eqeqeq - Related to #1597 #2562

diego-G commented Nov 21, 2018 •

edited

Loading

MaciejBaj left a comment

yatki left a comment

Apply eslint-rule eqeqeq - Related to #1597 #2562

Apply eslint-rule eqeqeq - Related to #1597 #2562

Conversation

diego-G commented Nov 21, 2018 • edited Loading

Review checklist

MaciejBaj left a comment

Choose a reason for hiding this comment

yatki left a comment

Choose a reason for hiding this comment

diego-G commented Nov 21, 2018 •

edited

Loading