Fix get last commit helper when git is not installed - Closes #2588 #2596

diego-G · 2018-11-28T17:20:10Z

How to test it?

mocha test/unit/helpers/git.js
mocha test/functional/http/get/node/node.js

Review checklist

The PR resolves getLastCommit fails if git is not installed #2588
All new code is covered with unit tests
All new code was formatted with Prettier
Linting passes
Tests pass
Commit messages follow the commit guidelines
Documentation has been added/updated

helpers/git.js

nazarhussain

Other than that issue, everything else seems fine.

helpers/git.js

fchavant

Works as expected.

diego-G added 2 commits November 28, 2018 17:26

Fix unit test for helper git

f3eee61

Fix #2588

e8a399a

diego-G added the 👁️ pending review label Nov 28, 2018

diego-G self-assigned this Nov 28, 2018

diego-G requested review from nazarhussain, MaciejBaj and fchavant November 28, 2018 17:20

nazarhussain suggested changes Nov 28, 2018

View reviewed changes

helpers/git.js Outdated Show resolved Hide resolved

MaciejBaj added 🏗️ in progress and removed 👁️ pending review labels Nov 29, 2018

diego-G added 2 commits November 29, 2018 14:10

Recover same logic to check for spawn stderr in git helper

c133c86

Merge branch 'development' into 2588-fix_getLastCommit_helper

634f74f

diego-G requested a review from nazarhussain November 29, 2018 13:11

diego-G added 👁️ pending review and removed 🏗️ in progress labels Nov 29, 2018

fchavant suggested changes Nov 29, 2018

View reviewed changes

helpers/git.js Show resolved Hide resolved

nazarhussain suggested changes Nov 29, 2018

View reviewed changes

helpers/git.js Show resolved Hide resolved

Get last commit from revision file in any error case

259320c

diego-G requested review from nazarhussain and fchavant November 29, 2018 16:17

fchavant approved these changes Nov 29, 2018

View reviewed changes

nazarhussain approved these changes Nov 29, 2018

View reviewed changes

MaciejBaj approved these changes Nov 30, 2018

View reviewed changes

MaciejBaj added ✅ ready and removed 👁️ pending review labels Nov 30, 2018

MaciejBaj merged commit c21a0af into development Dec 1, 2018

MaciejBaj deleted the 2588-fix_getLastCommit_helper branch December 1, 2018 17:57

MaciejBaj changed the title ~~Fix get last commit helper when git is not installed - Close #2588~~ Fix get last commit helper when git is not installed - Closes #2588 Dec 1, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix get last commit helper when git is not installed - Closes #2588 #2596

Fix get last commit helper when git is not installed - Closes #2588 #2596

diego-G commented Nov 28, 2018

nazarhussain left a comment

fchavant left a comment

Fix get last commit helper when git is not installed - Closes #2588 #2596

Fix get last commit helper when git is not installed - Closes #2588 #2596

Conversation

diego-G commented Nov 28, 2018

How to test it?

Review checklist

nazarhussain left a comment

Choose a reason for hiding this comment

fchavant left a comment

Choose a reason for hiding this comment