Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: use lisk-scripts 0.6.1 - Closes #2595 #2599

Merged
merged 1 commit into from Nov 30, 2018

Conversation

fchavant
Copy link
Contributor

What was the problem?

The build process needs to use lisk-scripts v0.6.1 for NODE_ENV to be set (LiskArchive/lisk-scripts#182).

How did I fix it?

Changed lisk-scripts version and checksum in build/config.sh.

How to test it?

  • run build (see build/README.md)
  • make sure lisk-scripts v0.6.1 are being used
  • run build and ensure the NODE_ENV variable is set to "production"

Review checklist

@fchavant fchavant self-assigned this Nov 29, 2018
@fchavant fchavant requested a review from yatki November 29, 2018 15:09
@MaciejBaj MaciejBaj added api and removed api labels Nov 30, 2018
@MaciejBaj MaciejBaj merged commit 0b61f72 into development Nov 30, 2018
@MaciejBaj MaciejBaj deleted the 2595-use-lisk-scripts-0.6.1 branch November 30, 2018 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use lisk-scripts version 0.6.1
4 participants