This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Do not process bundled transactions while node is syncing - Closes #2398 #2607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SargeKhan
previously approved these changes
Dec 4, 2018
MaciejBaj
changed the title
4miners
suggested changes
Dec 5, 2018
4miners
suggested changes
Dec 5, 2018
4miners
previously approved these changes
Dec 5, 2018
SargeKhan
previously approved these changes
Dec 5, 2018
4miners
previously approved these changes
Dec 5, 2018
It was conflicting with other tests after moving the transaction pool jobs registration to bind function.
diego-G
force-pushed
the
2398-do_not_process_bundled_transactions_while_syncing
branch
from
9a4d045
to
1eb6c0d
Compare
4miners
approved these changes
Dec 6, 2018
MaciejBaj
reviewed
Dec 6, 2018
| @@ -222,7 +222,7 @@ class Round { | |||
| } | |||
| }); | |||
| } | |||
| return Promise.resolve(); | |||
There was a problem hiding this comment.
@yatki strongly suggested to return null in these kind of cases instead of resolving promises. Test became unstable since we introduce this.
MaciejBaj
reviewed
Dec 6, 2018
| @@ -82,7 +82,7 @@ module.exports = function(configurations, network) { | |||
| // to update across all nodes. | |||
| setTimeout(() => { | |||
| resolve(); | |||
| }, 5000); | |||
| }, 10000); | |||
There was a problem hiding this comment.
Network test suite is failing due to the security time to wait for some actions is not enough. I've seen the same problem in propagation scenario.
MaciejBaj
approved these changes
Dec 7, 2018
MaciejBaj
approved these changes
Dec 7, 2018
…ons_while_syncing
MaciejBaj
deleted the
2398-do_not_process_bundled_transactions_while_syncing
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test it?
mocha test/unit/logic/transaction_pool.jsReview checklist