Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Improve number checks in create multisignature account #330

Closed
willclarktech opened this issue Nov 8, 2017 · 0 comments
Closed

Improve number checks in create multisignature account #330

willclarktech opened this issue Nov 8, 2017 · 0 comments
Assignees
@willclarktech
Labels
🐛bug *easy
Projects
Version 0.3.0 Sprint Board 13-11-17

Comments

@willclarktech
Copy link
Contributor

Expected behavior: Providing floats like 12.34 as a lifetime or minimum number of confirmations should throw an error.

Actual behavior: Floats are parsed as ints, i.e. rounded down and used silently
@willclarktech willclarktech added this to Issues in Version 0.3.0 Nov 8, 2017
@willclarktech willclarktech self-assigned this Nov 8, 2017
@willclarktech willclarktech moved this from Issues to Prioritised Issues in Version 0.3.0 Nov 8, 2017
@willclarktech willclarktech mentioned this issue Nov 14, 2017
Merged
@willclarktech willclarktech moved this from Issues to Issues with Pull Request in Sprint Board 13-11-17 Nov 14, 2017
@willclarktech willclarktech moved this from Issues with Pull Request to Completed Issues in Sprint Board 13-11-17 Nov 14, 2017
@willclarktech willclarktech moved this from Prioritised Issues to Completed Issues in Version 0.3.0 Nov 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@willclarktech willclarktech

Labels
🐛bug *easy
Projects
No open projects
Sprint Board 13-11-17
Completed Issues
Version 0.3.0
Completed Issues
Milestone
No milestone
Development

No branches or pull requests
1 participant
@willclarktech