This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Refines and mocks tests - Completes #25 #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaciejBaj
reviewed
Jun 22, 2017
commands/get.js
Outdated
|
|
||
| return output; | ||
|
|
||
| if( (userInput.options.json === true || config.json === true) && userInput.options.json !== false) { |
There was a problem hiding this comment.
if( ( -> if ((
also would be cool to have the same files formats convention across all the projects
There was a problem hiding this comment.
#33 addresses it, nevermind
MaciejBaj
reviewed
Jun 22, 2017
|
|
||
| }); | ||
|
|
||
| }); |
There was a problem hiding this comment.
missing empty line at the end
MaciejBaj
reviewed
Jun 22, 2017
package.json
Outdated
| @@ -34,7 +34,8 @@ | |||
| "mocha": "^3.3.0", | |||
| "nyc": "^10.3.2", | |||
| "should": "^11.2.1", | |||
| "sinon": "^2.3.1" | |||
| "sinon": "^2.3.1", | |||
| "sinon-as-promised": "^4.0.3" | |||
MaciejBaj
previously requested changes
Jun 22, 2017
toschdev
dismissed
MaciejBaj’s stale review
empty line in the end is fixed, everything else resolved
MaciejBaj
approved these changes
Jun 22, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes #25