This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Add encrypt command - Closes #61 #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toschdev
reviewed
Jul 7, 2017
test/commands/encrypt.js
Outdated
|
|
||
| const message = 'Hello Lisker'; | ||
| const secret = 'pass phrase'; | ||
| const recipient = '9396639332432599292L'; |
There was a problem hiding this comment.
Instead of an account Id, the encryption from lisk-js expects a publicKey
https://github.com/LiskHQ/lisk-js/blob/development/lib/transactions/crypto/sign.js#L91
willclarktech
force-pushed
the
61-command_encrypt
branch
3 times, most recently
from
1525621
to
2685f53
Compare
willclarktech
force-pushed
the
61-command_encrypt
branch
2 times, most recently
from
d333235
to
71d1680
Compare
willclarktech
force-pushed
the
61-command_encrypt
branch
from
71d1680
to
ce1b9ed
Compare
willclarktech
force-pushed
the
61-command_encrypt
branch
from
ce1b9ed
to
9adf8d1
Compare
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #61
Need to deal with output formatting etc, but thought I'd get some feedback at this stage.