Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUESTION] Adding favicon? #1331

Closed
4 tasks done
p6002 opened this issue Sep 24, 2023 · 12 comments
Closed
4 tasks done

[QUESTION] Adding favicon? #1331

p6002 opened this issue Sep 24, 2023 · 12 comments
Labels
✅ Fixed [ISSUE] Auto-Assigned to Tickets whose fix has been deployed 🤷‍♂️ Question [ISSUE] Further information is requested

Comments

@p6002
Copy link

p6002 commented Sep 24, 2023

Question

Nowhere can I find information on how to change the favicon. Can anyone give me a hint?

image

Category

Configuration

Please tick the boxes

@p6002 p6002 added the 🤷‍♂️ Question [ISSUE] Further information is requested label Sep 24, 2023
@liss-bot
Copy link
Collaborator

If you're enjoying Dashy, consider dropping us a ⭐
🤖 I'm a bot, and this message was automated

@p6002 p6002 changed the title [QUESTION] <title> [QUESTION] Adding favicon? Sep 24, 2023
@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Oct 15, 2023
@p6002
Copy link
Author

p6002 commented Oct 15, 2023

Unfortunately, putting the favicon.ico in /app/public did not change anything.
I want to change this icon:
image

@Bademeister9
Copy link

Bademeister9 commented Oct 15, 2023

Nevermind it is /app/public/img/icons
after that build your application with npm run build

Or you can change it in /app/dist/img/icons so you dont need to build it anymore

favicon

stepbystep

@p6002
Copy link
Author

p6002 commented Oct 15, 2023

I do not know what you mean, because the /app/dist/img/icons directory does not exist. I found the /app/dist/img/icons location inside the container and I'll try to change the icon manually somehow, hopefully the update won't replace it.

@Bademeister9
Copy link

Bademeister9 commented Oct 15, 2023

you can create a volume to outside of the container and change it that way. i don't really get it

The /app/dist only exist after build so before it is inside /app/public

@p6002
Copy link
Author

p6002 commented Oct 15, 2023

Unfortunately, changing the icons to my own did not have any effect. The icon still remains the same.
I will wait when this feature is added to the config file. I'm surprised that no one has come up with this before.

@Lissy93
Copy link
Owner

Lissy93 commented Oct 15, 2023

If after passing it in as a volume, if you visit https://[your-dashy-address]/favicon.ico - do you see your icon? If so, it's a browser caching issue, a hard refresh should resolve that. If not, it's not been properly passed with Docker.

In the meantime, I'll take another look for a better solution, as this has been asked a few times now

@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Oct 15, 2023
@cookandy
Copy link

I was able to get this working in Docker by mapping a local favicon.ico on my filesystem to /app/dist/favicon.ico in the container.

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Oct 25, 2023
@p6002
Copy link
Author

p6002 commented Oct 25, 2023

Will this be added to the config file so it can be changed like an icon on the dashboard?

@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Oct 26, 2023
@dev-mcheung
Copy link

I would be very carefully about mapping to /app/dist. If you try to rebuild the app at any point in time it will crash the app. I recommend mapping the one in /app/public. Unfortunately, there is still an issue with the build on docker startup in #1051 so you will have to run the Rebuild Application each time the docker restarts.

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Dec 11, 2023
@TheRealGramdalf
Copy link

TheRealGramdalf commented Jan 10, 2024

This seems to be related to #1290 (comment) - follow the link for a full explanation.

You can also set the favicon with the pageinfo.logo setting: https://dashy.to/docs/configuring#pageinfo

@CrazyWolf13
Copy link
Collaborator

Hi
This problems seems to be related to dashy not automatically rebuilding on changes, see #1479 and #1290 (comment)
A new release has just been published, which should fix this issue, so please upgrade to the latest version.
If this is not the case just respond back to this ticket and I'll reopen this issue.
Thanks and have a nice day.

@CrazyWolf13 CrazyWolf13 added the ✅ Fixed [ISSUE] Auto-Assigned to Tickets whose fix has been deployed label Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Fixed [ISSUE] Auto-Assigned to Tickets whose fix has been deployed 🤷‍♂️ Question [ISSUE] Further information is requested
Projects
None yet
Development

No branches or pull requests

8 participants