Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] #1343 Search for items with cyrillic titles dosnt work #1351

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

deneor
Copy link
Contributor

@deneor deneor commented Oct 18, 2023

deneor Quick deneor /issue_1343 → Lissy93/dashy Commits: 1 | Files Changed: 1 | Additions: 0 Powered by Pull Request Badge

Category:
Bugfix

Overview
Added support of non unicode languages in search.

Issue Number #1343

Code Quality Checklist

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors

@deneor deneor requested a review from Lissy93 as a code owner October 18, 2023 09:15
@vercel
Copy link

vercel bot commented Oct 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashy ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 9:15am

@netlify
Copy link

netlify bot commented Oct 18, 2023

👷 Deploy Preview for dashy-dev processing.

Name Link
🔨 Latest commit 84454b0
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/652fa21e56d41c00080a9803

@viezly
Copy link

viezly bot commented Oct 18, 2023

Changes preview:

Legend:

👀 Review pull request on Viezly

@deneor
Copy link
Contributor Author

deneor commented Nov 14, 2023

@Lissy93, hello! How about to merge this PR?

Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So sorry for the delay @deneor
Thanks for implementing, looks good to me, will merge shortly :)

@Lissy93 Lissy93 merged commit 6a39aaa into Lissy93:master Nov 14, 2023
14 checks passed
@liss-bot
Copy link
Collaborator

liss-bot commented Mar 3, 2024

The fix for this issue has now been released in 2.1.2 ✨

If you haven't done so already, please update your instance to 2.1.2 or later. See 2.1.2 for full info.

Feel free to reach out if you need any more support. If you are enjoying Dashy, consider supporting the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants