[BUG] Config options in router not honoured

[Lissy93]

Discussed in #542

^{Originally posted by lephtHanded March 8, 2022}
heya!
latest update (or my config) seems borked with the latest docker pull.
the routingMode and startingView options don't seem to have an effect.

i have mine set to hash and minimal respectively and the page loads to the default view.

links to ../minimal or ../#/minimal that I got working from this thread just open the default view now.

Probable Cause

The config isn't finished fetching when the router is initialised

[azerioxal]

I've been working on this for a long time now. startingView is a fairly simple fix, but I have not been having any luck in figuring out how to get routingMode to work.

Vue router only accepts the mode option being passed at initialization and it can't be changed at runtime. Since the config is now fetched this leads to the issue.

Do you have any ideas on a way to sort this out?

[Lissy93]

I guess the only option would be to use an environmental variable,
const mode = process.env.VUE_APP_ROUTING_MODE || 'history';

I was also thinking, since routing mode is unlikely to be something the user changes frequently it could be read statically at build time, but this doesn't seem very neat

[azerioxal]

The environment variable would work for reading at build time. Though, that would mean adding the build step back into the docker image. Which I guess isn't too bad as it would only have run on first start and change to that variable, but it would mean removing the ability to drop the size of the image by removing all the vue dependencies.

[Lissy93]

Ahh it's a tricky one. but I think for now, moving src/ back into the container is the only way to fix this

[azerioxal]

I've actually come up with a solution that works! We can add a script tag to the top of index.html that initializes before the Vue app and loads any variables needed before it, like routingMode.

This file can even be generated from conf.yml by the server. Those using a static host would have to edit the additional file if they want to change routingMode, but like you mentioned earlier, it's not something that will be changed often, if at all after the original setting.

This will allow us to keep shrinking the docker image, and not have to delay startup with a build. What're your thoughts?

[Lissy93]

Would that work? I think the Vue router stuff is compiled at build time- I might be wrong, but playing around with it that seemed to be the case. If it works, then that's awesome

[azerioxal]

It works in my testing. I think it feels like the router options are done at build time because of how they're loaded as soon as the Vue app starts up with main.js.

I'll submit it shortly for you to look at.

[lephtHanded]

you guys fixt it!
thank you!

[Lissy93]

Yay, nice one @ateroz! Glad it's working again now :)

[Lissy93]

Yay, nice one @ateroz! Glad it's working again now :)