Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE_REQUEST] Refresh URL when in Multi-Page #670

Closed
FormBurden opened this issue May 21, 2022 · 9 comments
Closed

[FEATURE_REQUEST] Refresh URL when in Multi-Page #670

FormBurden opened this issue May 21, 2022 · 9 comments
Labels
🦄 Feature Request [ISSUE] Suggestion for new feature, update or change

Comments

@FormBurden
Copy link

FormBurden commented May 21, 2022

Is your feature request related to a problem? If so, please describe.

Sorry, not sure if Feature Request or Bug.

I started using the Multi-Page feature which is awesome, but I noticed some odd things happening when refreshing the page from your browser when the URL is in a Multi-Page.

When refreshing while the url is in the Multi-Page i.e xxx.xxx.xx.xx:8080/home/widgets, if I refresh I will get a blank white page with: "Cannot GET /home/widgets" while the tab of the page states "Error". So in order to fix I would have to cut everything until just the "8080" part of the url to get back in. Or my Home button, because I have Dashy as my home page.

Is there any way around this or a fix? so it loads the page exactly, or even just defaults back to the home "8080"?

If it matters I edit my pages using the config instead of the editing method within Dashy.

Describe the solution you'd like

Refreshes will have the same page you're on, and/or when you refresh it just goes to the "home" page of Dashy.

Priority

Medium (Would be very useful)

Is this something you would be keen to implement

No response

@FormBurden FormBurden added the 🦄 Feature Request [ISSUE] Suggestion for new feature, update or change label May 21, 2022
@Lissy93
Copy link
Owner

Lissy93 commented May 21, 2022

Hmm, that does actually sounds like a bug. Lemme look into it and see if I can recreate it....
If you set appConfig.routingMode to hash, do you still experience the issue? How are you running Dashy, with Docker, you also using a proxy?

@FormBurden
Copy link
Author

FormBurden commented May 21, 2022

Oh sorry again, I'm running it on Docker-compose, and no proxy.

And I just updated to latest: 2.0.9 and enabled the routingMode to hash, and I can confirm that it works correctly when I refresh the page when I'm on a Multi-Page. So I'm guessing when routingMode is on "history", such as not putting routingMode into the config it bugs like what I stated before.

@liss-bot liss-bot added 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending and removed 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending labels May 21, 2022
@fonts4eva
Copy link

fonts4eva commented May 27, 2022

i am having the same issue with a docker doesnt seem to matter what routing mode i put it on, my other YML files will not load.

@liss-bot liss-bot added 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending and removed 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending labels May 27, 2022
@coalwater
Copy link

I also am experiencing the same bug

If you set appConfig.routingMode to hash, do you still experience the issue?

Yes this doesn't fix the issue for me

How are you running Dashy, with Docker, you also using a proxy

I'm running dashy using the docker image using a kubernetes deployment, behind Traefik proxy

Things I've tested:
Using a page called work I tried several paths and none worked
/home/work > this is the default link url and it doesn't work
/work > also doesn't work
I tried also both of the above with a trailing slash (ie: /home/work/) but also doesn't work

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Jun 2, 2022
@NSerbin
Copy link

NSerbin commented Jun 5, 2022

i have the same problem too

@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Jun 6, 2022
@Danie10
Copy link

Danie10 commented Jun 22, 2022

I have the identical issue with a docker container mapped to a volume. It is opening the added page, but any refresh of browser tab, gives the same error.

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Jun 22, 2022
@Lissy93
Copy link
Owner

Lissy93 commented Jun 23, 2022

If the issue is that multi-pages load on click, but not on direct navigation, then:
Under appConfig, set routingMode to hash. Then rebuild, and refresh the page.

If the issue is that a new page is never loading, then:
Check the browser console, and you'll see an error message explaining what's not working (likely either 404 not found, 401 unauthorized, or CORS).

@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Jun 23, 2022
@Danie10
Copy link

Danie10 commented Jun 24, 2022

Thanks @Lissy93 yes the routingMode settings seems to have solved the page reload issue.

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Jun 24, 2022
@Lissy93 Lissy93 closed this as completed Jun 24, 2022
@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Jun 24, 2022
@paxperscientiam
Copy link

If the issue is that multi-pages load on click, but not on direct navigation, then: Under appConfig, set routingMode to hash. Then rebuild, and refresh the page.

If the issue is that a new page is never loading, then: Check the browser console, and you'll see an error message explaining what's not working (likely either 404 not found, 401 unauthorized, or CORS).

Thank you, setting appConfig.routingMode to "hash" did it for me too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦄 Feature Request [ISSUE] Suggestion for new feature, update or change
Projects
None yet
Development

No branches or pull requests

8 participants