Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Dashy not reading valid config or saving config properly #831

Closed
5 tasks done
stancubed opened this issue Aug 3, 2022 · 11 comments
Closed
5 tasks done

[BUG] Dashy not reading valid config or saving config properly #831

stancubed opened this issue Aug 3, 2022 · 11 comments
Assignees
Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working

Comments

@stancubed
Copy link

Environment

Self-Hosted (Docker)

System

Ubuntu 20.04.4 LTS

Version

2.1.1

Describe the problem

Dashy is not reading my valid config.yml file when loading, so it shows "No Data Configured" and using the UI to view the config, it shows only:
[ "object Object" ]

When manually pasting in the valid config object to the "Edit Config" tool, it validates in UI but saving it only saves as:
[ "object Object" ]

There is no inode issue as both inside/outside the container the inode is the same. There are no errors on build or validation, none in the console, and none during manual build. Pasting the build log below!

build_log.txt

Happy to test anything or check somewhere else for more logs!

Additional info

No response

Please tick the boxes

@stancubed stancubed added the 🐛 Bug [ISSUE] Ticket describing something that isn't working label Aug 3, 2022
@liss-bot
Copy link
Collaborator

liss-bot commented Aug 3, 2022

If you're enjoying Dashy, consider dropping us a ⭐
🤖 I'm a bot, and this message was automated

@stancubed
Copy link
Author

I should mention that the build log is from a recent test of 2.1.0 but this is happening on both 2.1.1 and 2.1.0.

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Aug 3, 2022
@Lissy93
Copy link
Owner

Lissy93 commented Aug 3, 2022

#799

@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Aug 3, 2022
@stancubed
Copy link
Author

The strange thing is that I had this working for a few days until today! What could have caused this if it wasn't a code change?

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Aug 4, 2022
@Lissy93
Copy link
Owner

Lissy93 commented Aug 4, 2022

Yeah, this is really weird. I've not come across this issue before. The [ "object Object" ] means that the JSON hasn't been parsed/ not converted to string.

Everything in that log file looks alright, I guess it's a client-side bug. Could you share the contents of your browser console? (here's how).

There are a lot of problems with the current config system, the main one being that it's really slow to apply changed especially on low spec devices. I'm about 50% through re-writing it all at the moment, and that should fix everything. But I understand it's frustrating in the meantime.

@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Aug 4, 2022
@stancubed
Copy link
Author

Okay that's sort of what I was thinking too, but it's weird that there aren't any logged issues during the save process either. Attaching the logs here!

It could totally be a client issue -- is there where to config is translated before saving?

dashy-1659632635826.log

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Aug 4, 2022
@liss-bot
Copy link
Collaborator

liss-bot commented Sep 4, 2022

This issue has gone 6 weeks without an update. To keep the ticket open, please indicate that it is still relevant in a comment below. Otherwise it will be closed in 5 working days.

@liss-bot liss-bot added ⚰️ Stale [ISSUE] [PR] No activity for over 1 month and removed 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending labels Sep 4, 2022
@liss-bot
Copy link
Collaborator

This issue was automatically closed because it has been stalled for over 6 weeks with no activity.

@liss-bot liss-bot removed the ⚰️ Stale [ISSUE] [PR] No activity for over 1 month label Sep 10, 2022
@v1p0r
Copy link

v1p0r commented Dec 23, 2022

It's been a couple of months since the issue exist. I think it has something to do with the docker image, maybe try to make the config file in a separate folder so we can bind the folder instead a file, like other docker images that I have used?

@desrod
Copy link

desrod commented Sep 2, 2023

Chiming in as well, just installed Dashy here using the default instructions and it does not allow me to edit/save/load or change the configuration as well. Changes to ~/dashy-config.yml on the host side are seen inside the editor, but never reflected in the UI, and it always reports "No Data Configured".

I came here because I initially tried using "Homepage", but that's an even worse dumpster-fire of an attempt at service aggregation.

@CrazyWolf13
Copy link
Collaborator

Hi,
Please check out Dashy V3, it compledtely changes how config is fetched and saved, there are no more rebuilds required.

Keep in mind V3 has breaking changes:
https://github.com/Lissy93/dashy/releases/tag/3.0.0

If this is still an issue with V3.0.1 comment here and I'll reopen this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working
Projects
Status: Done
Development

No branches or pull requests

6 participants