Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] BASE_URL inconsistently used #857

Closed
5 tasks done
nealian opened this issue Aug 19, 2022 · 6 comments
Closed
5 tasks done

[BUG] BASE_URL inconsistently used #857

nealian opened this issue Aug 19, 2022 · 6 comments
Assignees
Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working

Comments

@nealian
Copy link
Contributor

nealian commented Aug 19, 2022

Environment

Self-Hosted (Docker)

System

No response

Version

2.1.1

Describe the problem

I have multiple apps running on a single domain name, so I run them at separate context paths, with Nginx up front as a reverse proxy to each. There wasn't anything obvious in the documentation about this except a vague nod to BASE_URL and VUE_APP_DOMAIN, and indeed, when setting those to the proper context path and fully-qualified base URL, respectively (which seems a little backward to me, but that's what VUE wants, so...), the app is mostly there... Except for a couple of important bits.

The initial loading screen (initialization.html) is complete and looks great, but once the build is complete, index.html and the loaded javascript mis-route two important urls.
First is much less important; loading-screen.css should, if I'm reading things right, only be relevant for a few seconds while everything else is loaded in behind the scenes, but still is specified as /loading-screen.css.
The second and most important file it fails on is conf.yml, which, again, is only specified in the result as /conf.yml.

This means that, in the default routing mode, the app immediately redirects the user to /404, which again, is not within the BASE_URL. In hash routing mode, the page stays at the index.html, or really at <scheme>://<domain>/${BASE_URL}/#/, but ends up as a mostly blank page with an empty loading bar across the top; with the default conf.yml with the only addition of appConfig.routingMode set to hash, this means a dark blue screen with a barely-differentiable black strip across the top.

There are a couple of ways to handle this on the Nginx side of things, like hard-coding those locations with redirections or rewriting query responses to change the path in these circumstances, but rather figured that could be handled here much easier and more permanently.

Additional info

No response

Please tick the boxes

@nealian nealian added the 🐛 Bug [ISSUE] Ticket describing something that isn't working label Aug 19, 2022
@liss-bot
Copy link
Collaborator

If you're enjoying Dashy, consider dropping us a ⭐
🤖 I'm a bot, and this message was automated

@liss-bot
Copy link
Collaborator

This issue has gone 6 weeks without an update. To keep the ticket open, please indicate that it is still relevant in a comment below. Otherwise it will be closed in 5 working days.

@liss-bot liss-bot added the ⚰️ Stale [ISSUE] [PR] No activity for over 1 month label Sep 19, 2022
@liss-bot
Copy link
Collaborator

This issue was automatically closed because it has been stalled for over 6 weeks with no activity.

@liss-bot liss-bot removed the ⚰️ Stale [ISSUE] [PR] No activity for over 1 month label Sep 25, 2022
@cchaudier
Copy link

cchaudier commented Dec 1, 2022

Hello, yesterday I did a live coding on dashy to deploy it on the GitLab pages. But I noticed that when there is a path, and therefore I have to fill the BASE_URL I had exactly the same behavior.

So I think it's a bug.

Here is the link of the part of my live on this problem:
https://youtu.be/H066hgnG5qI?t=5975

My code is here : https://lab.frogg.it/froggit/poc/dashy/-/tree/2-ci-deploy-on-froggit-pages

My page should be served here : https://froggit.froggit.page/poc/dashy/#/

I tried the v 2.1.0 but I have an almost identical behavior.

@Lissy93 can you re-open this issue ?

Et si l'on faisais un tableau de bord statique avec un accès sécurisé ?Héberge ton application sur Froggit pour quelques euros par mois ➡️ https://froggit.fr...
Dashboard with Dashy https://froggit.froggit.page/poc/dashy/

@zgurea1
Copy link

zgurea1 commented Feb 23, 2023

Hello guys, i got the same problem. There will be a fix?

@CrazyWolf13
Copy link
Collaborator

This is a duplicate of #1036 will close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working
Projects
Status: Done
Development

No branches or pull requests

6 participants