Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE_REQUEST] Base path option #923

Closed
Slyke opened this issue Sep 28, 2022 · 6 comments
Closed

[FEATURE_REQUEST] Base path option #923

Slyke opened this issue Sep 28, 2022 · 6 comments
Labels
🦄 Feature Request [ISSUE] Suggestion for new feature, update or change 🕸️ Inactive

Comments

@Slyke
Copy link

Slyke commented Sep 28, 2022

Is your feature request related to a problem? If so, please describe.

No response

Describe the solution you'd like

BasePath or similar option for when behind a reverse proxy.

I can run it fine by directly accessing the IP address, eg: 123.123.123.123:4000, but if this is placed behind a reverse proxy with a subpath Dashy doesn't load at all.

The reason is due to absolute pathing when loading assets.

Lets say Dashy is hosted at mydomain.com/dashy, all requests will go to mydomain.com/. For example when requesting the manifest.json file, I can see it tries to request from mydomain.com/manifest.json instead of mydomain.com/dashy/manifest.json.

Adding in a BasePath or relative pathing config option, will allow for letting Dashy know that it should be requesting from a subdirectory.

I quickly checked the Config docs, but couldn't see anything relevant: https://github.com/Lissy93/dashy/blob/master/docs/configuring.md

I would imagine this would fall under the appConfig section.

Priority

Medium (Would be very useful)

Is this something you would be keen to implement

Yes!

🚀 A self-hostable personal dashboard built for you. Includes status-checking, widgets, themes, icon packs, a UI editor and tons more! - dashy/configuring.md at master · Lissy93/dashy
@Slyke Slyke added the 🦄 Feature Request [ISSUE] Suggestion for new feature, update or change label Sep 28, 2022
@liss-bot
Copy link
Collaborator

This issue has gone 6 weeks without an update. To keep the ticket open, please indicate that it is still relevant in a comment below. Otherwise it will be closed in 5 working days.

@liss-bot liss-bot added the ⚰️ Stale [ISSUE] [PR] No activity for over 1 month label Oct 29, 2022
@Slyke
Copy link
Author

Slyke commented Oct 29, 2022

Yes, still relevant.

@liss-bot liss-bot added 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending and removed ⚰️ Stale [ISSUE] [PR] No activity for over 1 month labels Oct 29, 2022
@liss-bot
Copy link
Collaborator

This issue has gone 6 weeks without an update. To keep the ticket open, please indicate that it is still relevant in a comment below. Otherwise it will be closed in 5 working days.

@liss-bot liss-bot added ⚰️ Stale [ISSUE] [PR] No activity for over 1 month and removed 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending labels Nov 29, 2022
@Slyke
Copy link
Author

Slyke commented Nov 29, 2022

Yes, still relevant.

@liss-bot liss-bot added 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending and removed ⚰️ Stale [ISSUE] [PR] No activity for over 1 month labels Nov 29, 2022
@liss-bot
Copy link
Collaborator

This issue has gone 6 weeks without an update. To keep the ticket open, please indicate that it is still relevant in a comment below. Otherwise it will be closed in 5 working days.

@liss-bot liss-bot added ⚰️ Stale [ISSUE] [PR] No activity for over 1 month and removed 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending labels Dec 30, 2022
@liss-bot
Copy link
Collaborator

liss-bot commented Jan 5, 2023

This issue was automatically closed because it has been stalled for over 6 weeks with no activity.

@liss-bot liss-bot closed this as completed Jan 5, 2023
@liss-bot liss-bot removed the ⚰️ Stale [ISSUE] [PR] No activity for over 1 month label Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦄 Feature Request [ISSUE] Suggestion for new feature, update or change 🕸️ Inactive
Projects
None yet
Development

No branches or pull requests

2 participants