Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] MDI item icons in unicodeOpeningIcon() produce broken icons #959

Closed
5 tasks done
ndejong opened this issue Oct 24, 2022 · 5 comments
Closed
5 tasks done

[BUG] MDI item icons in unicodeOpeningIcon() produce broken icons #959

ndejong opened this issue Oct 24, 2022 · 5 comments
Assignees
Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working 🕸️ Inactive

Comments

@ndejong
Copy link

ndejong commented Oct 24, 2022

Environment

Self-Hosted (Docker)

System

Firefox 105.0.3, Docker

Version

docker.io/lissy93/dashy:2.1.1

Describe the problem

When using Material Design appConfig.theme: material there are small-icons that appear on the left-hand-side when hovering over these items

Note the broken icon to the left of the item
Screenshot from 2022-10-24 10-40-28

Checking out the HTML, these icon(s) are presented to the browser via an a-tag attribute that looks like this

style='--open-icon: "\f360";'

A quick bit of digging for the string f360 indicates that this is coming from a function unicodeOpeningIcon() located here

Searching for unicode \f360 seems to indicate this value belongs to a private or reserved value-space

Additional info

No response

Please tick the boxes

@ndejong ndejong added the 🐛 Bug [ISSUE] Ticket describing something that isn't working label Oct 24, 2022
@liss-bot
Copy link
Collaborator

If you're enjoying Dashy, consider dropping us a ⭐
🤖 I'm a bot, and this message was automated

@liss-bot
Copy link
Collaborator

This issue has gone 6 weeks without an update. To keep the ticket open, please indicate that it is still relevant in a comment below. Otherwise it will be closed in 5 working days.

@liss-bot liss-bot added the ⚰️ Stale [ISSUE] [PR] No activity for over 1 month label Nov 23, 2022
@liss-bot
Copy link
Collaborator

This issue was automatically closed because it has been stalled for over 6 weeks with no activity.

@liss-bot liss-bot removed the ⚰️ Stale [ISSUE] [PR] No activity for over 1 month label Nov 29, 2022
@Lissy93
Copy link
Owner

Lissy93 commented Dec 31, 2023

Hey @ndejong

You can fix this, by setting enableFontAwesome: true under appConfig.

See Troubleshooting --> Icons not Displaying for more info.

@ndejong
Copy link
Author

ndejong commented Jan 2, 2024

Ahh wow, I'd never have picked that out.

I had set appConfig.enableFontAwesome: false without knowing the material theme had a FA dependency.

I wonder if this type of theme dependency trap is common enough to warrant finding a way to surface the problem for users? I'm not a front-end tech-stack guy else I'd take a closer look to help out.

Thanks for taking the time to review and respond, Dashy is awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working 🕸️ Inactive
Projects
None yet
Development

No branches or pull requests

3 participants