Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEEDBACK] Update TfL Widget - Elizabeth line #997

Closed
ramzh opened this issue Dec 5, 2022 · 5 comments
Closed

[FEEDBACK] Update TfL Widget - Elizabeth line #997

ramzh opened this issue Dec 5, 2022 · 5 comments
Labels
🌈 Feedback [ISSUE] Tell us what you think of the project 🕸️ Inactive

Comments

@ramzh
Copy link

ramzh commented Dec 5, 2022

Hey Lissy!

Love your work and truly amazing with the widget. As a Londoneer myself , I set up the TfL widfget however I noticed that the Elizabeth line does not follow the same schema name as the others in the widget and widget options

image

  - name: 🚇 Transport for London
    widgets:
      - type: tfl-status
        options:
          showAll: true
          sortAlphabetically: true
          linesToShow:
          - Jubilee
          - Central
          - Elizabeth line

Would it be possible to update the widget and widget option to accept "Elizabeth" as option name? :)

Thanks again for the awesome tool!

@ramzh ramzh added the 🌈 Feedback [ISSUE] Tell us what you think of the project label Dec 5, 2022
@liss-bot
Copy link
Collaborator

liss-bot commented Jan 4, 2023

This issue has gone 6 weeks without an update. To keep the ticket open, please indicate that it is still relevant in a comment below. Otherwise it will be closed in 5 working days.

@liss-bot liss-bot added the ⚰️ Stale [ISSUE] [PR] No activity for over 1 month label Jan 4, 2023
@ramzh
Copy link
Author

ramzh commented Jan 7, 2023

still relevant

@liss-bot liss-bot added 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending and removed ⚰️ Stale [ISSUE] [PR] No activity for over 1 month 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending labels Jan 7, 2023
@liss-bot
Copy link
Collaborator

liss-bot commented Feb 8, 2023

This issue has gone 6 weeks without an update. To keep the ticket open, please indicate that it is still relevant in a comment below. Otherwise it will be closed in 5 working days.

@liss-bot liss-bot added the ⚰️ Stale [ISSUE] [PR] No activity for over 1 month label Feb 8, 2023
@liss-bot
Copy link
Collaborator

This issue was automatically closed because it has been stalled for over 6 weeks with no activity.

@liss-bot liss-bot removed the ⚰️ Stale [ISSUE] [PR] No activity for over 1 month label Feb 14, 2023
@Lissy93 Lissy93 reopened this Dec 31, 2023
@Lissy93
Copy link
Owner

Lissy93 commented Dec 31, 2023

Hey @ramzh, I am SO sorry for the late reply here.

I agree it's inconsistent, but it is actually correct.

This is because according to TfL it isn't technically a Tube line, since most of the route uses the National Rail network and infrastructure, and because the British Rail Class 345 trains which service the line are much larger than Tube trains.

Even the official TfL Status page calls it "Elizabeth Line" when all others are just called Central, District, Piccadilly, etc


Dashy is calling the API like this: https://api.tfl.gov.uk/line/mode/dlr,elizabeth-line,overground,tram,tube/status and then filtering based on the results passed by the user. So unless I hard-code something to allow for either "elizabeth" or "elizabeth line", then I'm afraid this isn't possible.

@Lissy93 Lissy93 closed this as completed Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌈 Feedback [ISSUE] Tell us what you think of the project 🕸️ Inactive
Projects
None yet
Development

No branches or pull requests

3 participants