Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: mitigate ppss.kr #7

Merged
merged 1 commit into from Aug 10, 2022
Merged

feat: mitigate ppss.kr #7

merged 1 commit into from Aug 10, 2022

Conversation

seia-soto
Copy link
Contributor

@seia-soto seia-soto commented Aug 10, 2022 •
edited

  • Organize fallback functions for additional runtime mitigation.
  • Add realistic random UUID generator.
  • Cleaned up some variables.
  • Removed secret value registration to Window to hide from capturing.
  • Updated version to 2.1.

The main reason to update is ppss.kr.

@seia-soto seia-soto self-assigned this Aug 10, 2022
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 10, 2022
View reviewed changes
microShield.user.js
unsafeWindow = window
}

const secret = (Date.now() * Math.random()).toString(36)

Check failure

Code scanning / CodeQL

Insecure randomness

Cryptographically insecure [random value](1) in a security context.
microShield.user.js
} catch (_error) { }
}

document.cookie = 'as_uuid=; expires=-1'

Check warning

Code scanning / CodeQL

Clear text transmission of sensitive cookie

Sensitive cookie sent without enforcing SSL encryption
microShield.user.js
}

document.cookie = 'as_uuid=; expires=-1'
document.cookie = 'as_uuid='

Check warning

Code scanning / CodeQL

Clear text transmission of sensitive cookie

Sensitive cookie sent without enforcing SSL encryption
@piquark6046 piquark6046 self-requested a review August 10, 2022 16:24
piquark6046
piquark6046 approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@piquark6046 piquark6046 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 🥳

@piquark6046 piquark6046 merged commit e346e9d into List-KR:main Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piquark6046 piquark6046 piquark6046 approved these changes

Assignees

@seia-soto seia-soto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@seia-soto @piquark6046