Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Users to select any card as a commander #41

Open
4 tasks
Elonex777 opened this issue May 25, 2020 · 1 comment
Open
4 tasks

Allow Users to select any card as a commander #41

Elonex777 opened this issue May 25, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@Elonex777
Copy link
Collaborator

Elonex777 commented May 25, 2020

Like #50 Should have something that convey they are not official: like a sticker and be able to toggle it on/off on the settings (would be useful for printing purpose)

Alignments Values of the most obvious one:

  • Banned
  • Extra Silver Border
  • Heroes of the Realm
  • Nephilims, maelstrom angel, Genju of the Realm, Budoka Gardener, Elbrus, the Binding Blade, Tamanoa, Ankle Shanker, Westvale Abbey
@Elonex777
Copy link
Collaborator Author

Elonex777 commented May 25, 2020

Lithl comment on the security:

If the user enters a custom choice for a commander, then we have two options: the client queries Scryfall directly, or the client asks the server to query Scryfall. If the client queries Scryfall, then it's possible to perform a man-in-the-middle attack to inject malicious data into the program. (The structure of the program limits what malicious code could accomplish, but the potential is there.) If the server is asked to query Scryfall, then we are sending user input to the server, which always carries risk, period.
[08:02]
For example, the server already has code to prevent something like /images/../../../somerandomfile.txt which would access somerandomfile.txt on the server outside of the program root.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants