Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarity around logFC for gene_stats #9

Closed
AMChalkie opened this issue May 22, 2020 · 3 comments
Closed

Clarity around logFC for gene_stats #9

AMChalkie opened this issue May 22, 2020 · 3 comments

Comments

@AMChalkie
Copy link

Hi,

  1. For sgRNA the code is
    log2(est$cpm_b + 1) - log2(est$cpm_a + 1)
  2. And for gene level:
    mean(logFC) of all sgRNA in that gene.

This has the unfortunate effect that if you try and re-calculate the logFC from the cpm values in the sheet level data, you get a difference. It is worth being explicit about this, or having multiple CPMs (although that would create confusion).

Best wishes
Alistair

@hyunhwan-jeong
Copy link
Owner

Thanks for the report, and there have been some changes to clarify the logFC.

First, the logFC_level argument has been added. The default value of the argument is set to "sgRNA" (i.e. it will be set to "sgRNA" if there is no value is assigned) because to make the default mode produces the same result what the previous version had produced. In the later version, it is possible to change the default value.

https://github.com/LiuzLab/CB2/blob/5aeef4b5efd4c7ce82f9b1c11d5159d075275c97/man/measure_gene_stats.Rd#L12

Second, in the documentation, I have added the detailed description as follows:
https://github.com/LiuzLab/CB2/blob/5aeef4b5efd4c7ce82f9b1c11d5159d075275c97/man/measure_gene_stats.Rd#L21

To test the latest version, please use devtools to install. I will submit it to cran.

Thanks,

Hyun-Hwan Jeong

@AMChalkie
Copy link
Author

AMChalkie commented May 27, 2020 via email

@hyunhwan-jeong
Copy link
Owner

It is now available in cran.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants