Skip to content
This repository has been archived by the owner on May 2, 2023. It is now read-only.

In version 1.4.x, WebSocket is closed by each refreshSession! #134

Open
ShigeruNakagaki opened this issue Oct 14, 2020 · 6 comments
Open

Comments

@ShigeruNakagaki
Copy link

ShigeruNakagaki commented Oct 14, 2020

before version 1.4.x, WebSocket is not closed by refreshSession.
but in version 1.4.x, In version 1.4.x, WebSocket is closed by each refreshSession!
If refreshSessionInterval is 10 minutes, WebSocket will be closed at each 10 minutes. And We need to reconnect each 10 minutes.
This is an awful degrade bug.

@map34
Copy link
Contributor

map34 commented Oct 14, 2020

Hi @ShigeruNakagaki, could you let us know what your account number is?

@ShigeruNakagaki
Copy link
Author

Hi, map34.
I don't want to talk about our account here.
We have already explained this to Live Person Japan. However, they did not understand what is a problem.

@ShigeruNakagaki ShigeruNakagaki changed the title In version 1.4.5, WebSocket is closed by each refreshSession! In version 1.4.x, WebSocket is closed by each refreshSession! Oct 15, 2020
@ShigeruNakagaki
Copy link
Author

Hi, map34

I wasn't accurate.
v1.3.2 is OK. but 1.4.x is not ok.

@ShigeruNakagaki
Copy link
Author

Well, I'm checking each version now.

v 1.3.2 is OK.
v 1.4.0 received 401 error at refresh timing and this is not ok.
v 1.4.1 received 401 error at refresh timing and WebSocket was closed. this is so wrong.

@ShigeruNakagaki
Copy link
Author

this fix is so wrong.

this._handleLoginAndReconnect(domains, 'RefreshSession#Relogin#WS', callback);

please, do not reconnect when it received 401 at refreshing session.
What is wrong is to receive 401 at refreshing session.
it should be refresh session without 401 response.

thanks

@ShigeruNakagaki
Copy link
Author

ShigeruNakagaki commented Oct 15, 2020

Every single refreshSession receives 401 response.
Don't you think this itself is wrong?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants