Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Integer.SIZE to Long.SIZE in BitHelper #11

Merged
merged 1 commit into from May 24, 2019
Merged

Update Integer.SIZE to Long.SIZE in BitHelper #11

merged 1 commit into from May 24, 2019

Conversation

brucesw
Copy link
Contributor

@brucesw brucesw commented Apr 28, 2019

I believe the getLeftmostBits method of the BitHelper class should throw IllegalArgumentException(String.format("numBits must be < %d", Long.SIZE)) instead of IllegalArgumentException(String.format("numBits must be < %d", Integer.SIZE)) because the conditional checks numBits against Long.SIZE and not Integer.SIZE.

@brucesw brucesw requested a review from sherifnada April 28, 2019 23:05
ChristianHansen
ChristianHansen approved these changes May 9, 2019
View reviewed changes
Copy link
Contributor

@ChristianHansen ChristianHansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the slow review here. This looks good to me.

@brucesw brucesw merged commit f7bb68b into master May 24, 2019
@delete-merged-branch delete-merged-branch bot deleted the update-bithelper branch May 24, 2019 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristianHansen ChristianHansen ChristianHansen approved these changes

@sherifnada sherifnada Awaiting requested review from sherifnada

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brucesw @ChristianHansen