Add tunable HyperMinHash impl #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* interface-based groundwork * clean up doc * Use interfaces * cleanup * update doc * doc strings, appease checkstyle
* wip * but out shared logic WIP * WIP tunable impl * add comment explaining LSB-aligned packing * long packer * change ifaces and add HMH Combiner * I need to learn to read * HMH Combiner code complete * how many hours does it take to write one class * add bias, remove unused param * add HyperMinHash serde, combiner, and implement IntersectionSketch for HMH * cardinality estimation * don't take the derivative * a bunch of stuff * add linear counting support * push serde tests and random test runner * wip tests * tests build, but do not pass * use collections * Fix tests 🕺🏼 🔥 (⌐■_■) * Test tunable impl (#4) * change README * praise baby jesus * remove comment * goddamn goddamn * handle out of order points * add notice * p >= 4
| } | ||
|
|
||
| /** | ||
| * @param _128BitHash | ||
| * Create a BetaMinHash from the serialized representation returned by {@link #getBytes()}. |
There was a problem hiding this comment.
This comment should be updated to reference the SerDe class
| } | ||
|
|
||
| public long cardinality() { | ||
| return BetaMinHashCardinalityGetter.cardinality(this); | ||
| // @Override |
There was a problem hiding this comment.
Need to remove this. We shouldn't have commented-out code checked in
There was a problem hiding this comment.
Need to implement a SerDe class instead.
There was a problem hiding this comment.
replaced with BetaMinHashSerde
|
|
||
| @Override | ||
| public boolean offer(byte[] bytes) { | ||
| // MetroHash128 hash = MetroHash.hash128(HASH_SEED, bytes); |
There was a problem hiding this comment.
We should remove this
add BetaMinHash Serde and tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up a lot of the repo and adds
HyperMinHash, an implementation that is based onHyperLogLogwith the addition of bias correction fromHyperLogLog++.