Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect AtomicDateTime serialization when serializing Attempt struct to JSON #2307

Open
rpgrca opened this issue Jan 23, 2023 · 1 comment
Open

Incorrect AtomicDateTime serialization when serializing Attempt struct to JSON #2307

rpgrca opened this issue Jan 23, 2023 · 1 comment
Labels
bug Reports unexpected behavior (or for a PR: fixes unexpected behavior).

Comments

@rpgrca
Copy link
Contributor

rpgrca commented Jan 23, 2023

Came back to write some more unit tests and noticed the AtomicDateTime does not have a ToString() overload for when an Attempt struct is serialized to JSON, thus serializing to their type name. These methods might not be used right now and thus it might not have been caught still but are latent.

image

My intention was to only add tests and refrain from fixing code problems so that the PR can be accepted without too much thinking, so I'm documenting this problem to come back and fix it once I PR the tests.
@wooferzfg wooferzfg added the bug Reports unexpected behavior (or for a PR: fixes unexpected behavior). label Jan 23, 2023
@rpgrca
Copy link
Contributor Author

rpgrca commented Feb 25, 2023

Hi there, I was wondering if you had the time to review #2308 so that I can fix this bug and continue adding more unit tests to the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Reports unexpected behavior (or for a PR: fixes unexpected behavior).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wooferzfg @rpgrca