Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading game/categories from SpeedrunComSharp causes hanging when opening splits #2490

Open
wooferzfg opened this issue May 2, 2024 · 0 comments
Labels
bug Reports unexpected behavior (or for a PR: fixes unexpected behavior).

Comments

@wooferzfg
Copy link
Member

wooferzfg commented May 2, 2024

The game and category parse functions are really slow, which could maybe be the cause:

These are accessed in RunMetadata: https://github.com/LiveSplit/LiveSplit/blob/master/src/LiveSplit.Core/Model/RunMetadata.cs

If a splits file has a game name that can't be found on Speedrun.com, or if the API request is cached (which includes caching the parsed object), the splits file loads a couple seconds sooner.

@wooferzfg wooferzfg added the bug Reports unexpected behavior (or for a PR: fixes unexpected behavior). label May 2, 2024
@wooferzfg wooferzfg changed the title JSON parsing in SpeedrunComSharp causes hanging when opening splits Loading game/categories from SpeedrunComSharp causes hanging when opening splits May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Reports unexpected behavior (or for a PR: fixes unexpected behavior).
Projects
None yet
Development

No branches or pull requests

1 participant