Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More uniform methods for emulators #89

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

Jujstme
Copy link
Contributor

@Jujstme Jujstme commented Jan 22, 2024

This commit tweaks the logic inside the emulator modules in order to let have have a uniform naming scheme for their functions.

Each emulator module will now have the following functions:

  • get_address() -> Address: can be used at any point in an autosplitter to convert a game system's physical memory address to the corresponding memory address in the emulator process' virtual memory space
  • check_bounds() -> bool: will check if a memory reading operation does not exceed the memory bounds of the emulated system
  • read::<T>: As before, allows to read any value from the emulated RAM
  • read_pointer_path::<T>: valid only for 32bit systems and above, allows to resolve pointer paths

Additionally, the specific commit for Genesis emulators also fixes #86

Jujstme added a commit to Jujstme/asr that referenced this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect memory readings on SEGA Genesis emulator
1 participant