Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more than 30,000 operation can't be performed in one transaction #60

Closed
Zuchos opened this issue Sep 20, 2018 · 1 comment
Closed

Comments

@Zuchos
Copy link

Zuchos commented Sep 20, 2018

Thre is a problem in Protocol class. When a transaction is executed (in Protoco.send) locks on concurrentOpt are aquired. The issue is when the number of operations in transaction + 1 is greater than the MaxConcurrentRequestsOpt that is defaulted to 30,000 the operation hangs forever, since that's the way the semaphore.acquire(count) works.
Of course the limit might be adjusted, but when the limit is reached, Protocol will freeze the whole execution.

Solution would be to perform check if the number of requested concurrent operations reached the limit value.

Besides that I wonder why every single operation in transaction is treated as concurrent operation? The transaction is executed in a single thread.

@Zuchos Zuchos changed the title No more that 30,000 operation can't be performed in one transaction No more than 30,000 operation can't be performed in one transaction Sep 21, 2018
@quentinms
Copy link
Member

Closing this as the repository is no longer maintained, and the issue is already in scredis/scredis#45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants