Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column 3 accepts (case-insensitive): [true, false, 0, 1], extend this to other cases: "Correct" "Wrong" #54

Open
kasra-hosseini opened this issue Jul 12, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects

Comments

@kasra-hosseini
Copy link
Member

kasra-hosseini commented Jul 12, 2020

Extend list of accepted values for positive matches.

Change data_processing.py (see in particular lines 37-43, but you may have to do other changes in subsequent lines) so it also accepts, positive, negative, correct, and wrong:

for i in range(len(df_list)):
  tmp_split_row = df_list[i].split(csv_sep)
  if str(tmp_split_row[2]).strip().lower() not in ["true", "false", "1", "0"]:
    print(f"SKIP: {df_list[i]}")
    # change the label to remove_me,
    # we drop the rows with no true|false in the label column
    tmp_split_row = f"X{csv_sep}X{csv_sep}remove_me".split(csv_sep)
@kasra-hosseini kasra-hosseini created this issue from a note in V1.1.0 (To do) Jul 12, 2020
@kasra-hosseini kasra-hosseini mentioned this issue Jul 12, 2020
4 tasks
@kasra-hosseini kasra-hosseini moved this from To do to In progress in V1.1.0 Jul 28, 2020
@kasra-hosseini kasra-hosseini moved this from In progress to To do in V1.1.0 Jul 28, 2020
@kasra-hosseini kasra-hosseini moved this from To do to In progress in V1.1.0 Aug 10, 2020
@kasra-hosseini kasra-hosseini moved this from In progress to Upcoming in V1.1.0 Aug 10, 2020
@kasra-hosseini kasra-hosseini removed this from Upcoming in V1.1.0 Aug 10, 2020
@kasra-hosseini kasra-hosseini added this to To do in V1.4.0 via automation Aug 10, 2020
@kasra-hosseini kasra-hosseini moved this from Backlog to Upcoming in V1.4.0 Dec 3, 2020
@kasra-hosseini kasra-hosseini added the enhancement New feature or request label Dec 3, 2020
@mcollardanuy mcollardanuy moved this from Upcoming to Backlog in V1.4.0 Jul 20, 2021
@mcollardanuy mcollardanuy added the help wanted Extra attention is needed label Jul 20, 2021
@mcollardanuy mcollardanuy moved this from Backlog to Upcoming in V1.4.0 Jul 20, 2021
@mcollardanuy mcollardanuy moved this from Upcoming to Backlog in V1.4.0 Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
V1.4.0
  
Backlog
Development

No branches or pull requests

2 participants