Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #26

Merged
merged 17 commits into from Feb 25, 2022
Merged

Dev #26

merged 17 commits into from Feb 25, 2022

Conversation

ChristinaLast
Copy link
Collaborator

@ChristinaLast ChristinaLast commented Feb 2, 2022

Creating requirements.txt from pyproject.toml to generate package list needed for binderhub build

Commands run:

  • to generate requirements.txt
poetry export -f requirements.txt --output requirements.txt --without-hashes

After doing this, I am required to add the github repo manually to the requirements.txt file to install MapReader such as:

git+https://github.com/Living-with-machines/MapReader@main#egg=mapreader

@ChristinaLast ChristinaLast linked an issue Feb 2, 2022 that may be closed by this pull request
2 tasks
@ChristinaLast ChristinaLast added this to In progress in Project board via automation Feb 2, 2022
@ChristinaLast ChristinaLast self-assigned this Feb 2, 2022
@ChristinaLast ChristinaLast removed this from In progress in Project board Feb 2, 2022
pyproj version: 3.3.0 [PROJ version: 8.2.0]

optional arguments:
  -h, --help     show this help message and exit
  -v, --verbose  Show verbose debugging version information.

commands:
  {sync} version to 3.2.1
pyproj version: 3.3.0 [PROJ version: 8.2.0]

optional arguments:
  -h, --help     show this help message and exit
  -v, --verbose  Show verbose debugging version information.

commands:
  {sync} to 3.2.1
@andrewphilipsmith
Copy link
Collaborator

I can now install MapReader locally, from this branch, using "Method 2" from the README.md.

From what is described here, I think that the updated poetry.lock file should be included in the repo:
https://python-poetry.org/docs/basic-usage/#commit-your-poetrylock-file-to-version-control

Christina, I would have more confidence in your dev setup than mine at the moment, so it is probably better if you do this?

@kasra-hosseini kasra-hosseini merged commit a8e0f51 into main Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploying MapReader through binder
3 participants