Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #38

Merged
merged 61 commits into from Apr 27, 2022
Merged

Update README.md #38

merged 61 commits into from Apr 27, 2022

Conversation

kasra-hosseini
Copy link
Member

@kasra-hosseini kasra-hosseini commented Apr 18, 2022

@kasra-hosseini kasra-hosseini marked this pull request as ready for review April 19, 2022 08:38
dcsw2 and others added 4 commits April 25, 2022 14:14
I've proposed removing 'originally' since we want to emphasise the ongoing nature of the library
I've restored the order to 'maps' -> 'images' so we get a clearer narative as in the current existing repo; and shortened / combined a sentence, as it was repeating 'non-maps' and 'maps', so I used 'any images' instead to make it more intuitive to read.

I was also going to add a few sentences giving the nice positive spin about interdisciplinary cross-pollination of image analysis, but not sure where this should go: I don't want to break the flow to the instructions, so perhaps it can go after the bullet points?
@kmcdono2

This comment was marked as resolved.

@kmcdono2

This comment was marked as resolved.

@kasra-hosseini

This comment was marked as resolved.

@kasra-hosseini

This comment was marked as resolved.

README.md Show resolved Hide resolved
@kasra-hosseini kasra-hosseini mentioned this pull request Apr 26, 2022
@kasra-hosseini
Copy link
Member Author

@kmcdono2 @dcsw2 Please let me know if you have any other comments/edits. If not, I will go ahead this evening and merge this into main.

@dcsw2

This comment was marked as resolved.

@kasra-hosseini kasra-hosseini merged commit 7c268d1 into main Apr 27, 2022
@rwood-97 rwood-97 deleted the restructure-readme-kh branch April 5, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants