Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Any concern for using math.sqrt instead of torch.sqrt #57

Closed
wenmin-wu opened this issue Feb 3, 2021 · 2 comments
Closed

Any concern for using math.sqrt instead of torch.sqrt #57

wenmin-wu opened this issue Feb 3, 2021 · 2 comments

Comments

@wenmin-wu
Copy link

I find you use a lot of math.sqrt in your implementation. Any concern for not using torch.sqrt instead? I think math.sqrt is slower than torch.sqrt because it's on CPU.
@LiyuanLucasLiu
Copy link
Owner

I believe since those computations take float numbers as inputs (instead of tensor), it should not be a problem.

@wenmin-wu
Copy link
Author

Got it, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wenmin-wu @LiyuanLucasLiu