Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move the Sample class into the Rust implementation #56

Open
Llandy3d opened this issue Feb 25, 2024 · 0 comments
Open

move the Sample class into the Rust implementation #56

Llandy3d opened this issue Feb 25, 2024 · 0 comments

Comments

@Llandy3d
Copy link
Owner

Currently pytheus-backend-rs has a OutSample class used to send the samples back to python, this was done because we couldn't duplicate the Sample class name as it was needed for both receiving samples & returning them.

With the new sample generation refactor the rust backend it's not using the Sample class at all. This means that it can be considered to actually move the implementation in there and get rid of the OutSample class altogether, this could open the consideration of moving the core pieces of the library in there as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant