infinite loop using beer-scented teddy bear as restore

[taltamir]

Context

• KolMafia version: r19757
• Class: accordion thief
• Run type (Casual/Normal/Hardcore/Aftercore): hardcore
• Challenge Path (Standard/Path Name/None): standard
• Number of Ascensions: 300+
• Are you using the beta version of autoscend?: beta

Failure Information (for bugs)

Autoscend got into an infinite loop trying to use beer-scented teddy bear as a restorer.
I used esc button to terminate it and recorded the stack trace on it

Failure Logs

[INFO] - Using item beer scented teddy bear as restore.
(usable quantity of beer-scented teddy bear is limited to 0 by needed restoration)
[INFO] - Using item beer scented teddy bear as restore.
(usable quantity of beer-scented teddy bear is limited to 0 by needed restoration)
[INFO] - Using item beer scented teddy bear as restore.
(usable quantity of beer-scented teddy bear is limited to 0 by needed restoration)
[INFO] - Using item beer scented teddy bear as restore.
(usable quantity of beer-scented teddy bear is limited to 0 by needed restoration)
[INFO] - Using item beer scented teddy bear as restore.
(usable quantity of beer-scented teddy bear is limited to 0 by needed restoration)
Stack trace:
KoLmafia declares world peace.
  at resource_value_per_meat_spent (auto_restore.ash:614)
  at __calculate_objective_values (auto_restore.ash:761)
  at calculate_objective_values (auto_restore.ash:1039)
  at __maximize_restore_options (auto_restore.ash:1054)
  at __restore (auto_restore.ash:1193)
  at acquireMP (auto_restore.ash:1300)
  at acquireMP (auto_restore.ash:1272)
  at handlePreAdventure (auto_pre_adv.ash:478)
  at handlePreAdventure (auto_pre_adv.ash:6)

Stack trace:
  at autoAdv (auto_adventure.ash:74)
  at LX_steelOrgan (autoscend.ash:3665)
  at doTasks (autoscend.ash:5972)
  at auto_begin (autoscend.ash:6218)
  at safe_preference_reset_wrapper (autoscend.ash:6287)
  at safe_preference_reset_wrapper (autoscend.ash:6294)
  at safe_preference_reset_wrapper (autoscend.ash:6294)
  at safe_preference_reset_wrapper (autoscend.ash:6294)
  at main (autoscend.ash:6322)

[taltamir]

Running autoscend again after aborting above got into the same infinite loop again. I aborted again.

My stats were:
HP 283/283
MP 24/173

Used it manually resulted int + 20 MP.

[jeparo]

https://sourceforge.net/p/kolmafia/code/HEAD/tree/src/data/restores.txt#l17

Mafia thinks beer-scented teddy bear is a HP restorer, and so is (incorrectly) blocking us from (correctly!) using it at full HP. Neat. Reported to Mafia.

[jeparo]

Fixed in r19768 of Mafia:

Revision 19768 by veracity0:
beer-scented teddy bear restores mp, not hp