Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge bindings folder between core and dashboard folders #334

Open
Ynng opened this issue Aug 10, 2023 · 1 comment
Open

Merge bindings folder between core and dashboard folders #334

Ynng opened this issue Aug 10, 2023 · 1 comment
Assignees
@CheatCod @jhuang38

Comments

@Ynng
Copy link
Member

Ynng commented Aug 10, 2023

Since we have a monorepo now, we don't need two copies of ts-rs bindings.

The problem is we manually editted some ts-rs bindings before, which is bad.
The auto generated ts-rs bindings currently don't work, due to some bigint/number issues.
Aleph-Alpha/ts-rs#94

We should use ts-rs and serde macros in core to make these bindings usable.
@CheatCod
Copy link
Member

https://serde.rs/field-attrs.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CheatCod CheatCod

@jhuang38 jhuang38

Labels
None yet
Projects
Lodestone
Status: 🔖 Ready to Start
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Ynng @CheatCod @jhuang38