Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tree node id as a key for Row component #33

Closed
Lodin opened this issue Oct 6, 2020 · 0 comments · Fixed by #44
Closed

Use tree node id as a key for Row component #33

Lodin opened this issue Oct 6, 2020 · 0 comments · Fixed by #44
Assignees
@Lodin
Labels
feature request
Milestone
3.0

Comments

@Lodin
Copy link
Owner

Lodin commented Oct 6, 2020

To reduce amount of re-painting, the Row component can use the node's id as the key through the getItemKey() function provided by react-window. That should also improve the performance when tree opens/closes.

Breaking change

This issue, however, requires removing the symbol support for the node's id because React is able to use only string keys.
@Lodin Lodin added this to the 3.0 milestone Oct 6, 2020
@Lodin Lodin self-assigned this Oct 6, 2020
@Lodin Lodin mentioned this issue Nov 15, 2020
Merged
@Lodin Lodin closed this as completed in #44 Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lodin Lodin

Labels
feature request
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

Use node ID as react element key Lodin/react-vtree
1 participant
@Lodin