Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for openSUSE Leap distributions #18

Merged
merged 1 commit into from Aug 18, 2017

Conversation

hwoarang
Copy link
Contributor

openSUSE Leap does not have a bird package in the official distribution
or development repositories so we use the one from CentOS7.

@logan2211
Copy link
Owner

Thanks. Looks good.. can you add testing? I think you'll just need to enable it by adding a travis matrix item like https://github.com/Logan2211/ansible-unbound/blob/ac67fde62dd81599b8a1b81f637bb264191d5b55/.travis.yml#L47-L51

openSUSE Leap does not have a bird package in the official distribution
or development repositories so we use the one from CentOS7. This also
adds travis support for testing against openSUSE.
@hwoarang
Copy link
Contributor Author

@logan2211 it seems that the opensuse 42.2 docker images do not have a valid 'ansible_default_ipv4' variable set. See

https://travis-ci.org/Logan2211/ansible-bird/jobs/265938315

I am not sure if I need to override that in the role or fix the docker images somehow.

@logan2211
Copy link
Owner

Sounds like either a bug with the docker image or maybe a race condition where facts were collected before the image got its IP. Will check into it and try to see whats up.

@hwoarang
Copy link
Contributor Author

@logan2211 I think the image may be missing the iproute2 package and that's why it may not be able to find this fact. I will fix it

@logan2211
Copy link
Owner

That might fix the etcd test too.

@logan2211 logan2211 merged commit 7f27651 into logan2211:master Aug 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants