Avoid jinja2 in when warnings #3
Conversation
defaults/main.yml
Outdated
| @@ -13,9 +14,6 @@ | |||
| # See the License for the specific language governing permissions and | |||
| # limitations under the License. | |||
|
|
|||
| # Can be used to completely disable the role's handler actions | |||
| haproxy_management: "{{ haproxy_hosts | default([]) | length > 0 }}" | |||
There was a problem hiding this comment.
Let's leave this in and default it to yes so there is still a way for someone to completely disable the role actions even if haproxy is present.
There was a problem hiding this comment.
Actually I wonder if it might work to simply remove the jinja brackets from this var default and set it to:
haproxy_management: 'haproxy_hosts | default([]) | length > 0'
with no other changes
There was a problem hiding this comment.
You'd still need that jinja2 to be evaluated, though.
handlers/main.yml
Outdated
| @@ -26,5 +27,5 @@ | |||
| weight: "{{ haproxy_weight | default(omit) }}" | |||
| delegate_to: "{{ item }}" | |||
| with_items: "{{ haproxy_hosts }}" | |||
| when: haproxy_management | bool | |||
| when: haproxy_hosts | default([]) | length > 0 | |||
There was a problem hiding this comment.
following on the above comment id suggest doing this:
when:
- haproxy_hosts | default([]) | length > 0
- haproxy_management | bool
This patch adjusts the handler to use the jinja2 statement directly
rather than using a variable with delimiters. This will hopefully
avoid the warning we currently see in OpenStack-Ansible:
[WARNING]: when statements should not include jinja2 templating
delimiters such as {{ }} or {% %}.
Found: {{ groups['haproxy'] | default([]) | length > 0 }}
|
I tried another strategy. We do a check to see if there are haproxy hosts and we also check to see if |
| @@ -14,7 +15,7 @@ | |||
| # limitations under the License. | |||
|
|
|||
| # Can be used to completely disable the role's handler actions | |||
| haproxy_management: "{{ haproxy_hosts | default([]) | length > 0 }}" | |||
| haproxy_management: yes | |||
There was a problem hiding this comment.
Can you trim the whitespace at the end of the line
This patch adjusts the handler to use the jinja2 statement directly
rather than using a variable with delimiters. This will hopefully
avoid the warning we currently see in OpenStack-Ansible: