fix stco in trailing moov #1056
Merged
+18
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't say that much about the code quality for a review, but as the original author of the forum post mentioned, I did test this patch, and it does resolve the original issue. |
| @@ -252,13 +252,13 @@ sub parseStream { | |||
| my $offset = $args->{_offset}; | |||
| my $log = logger('player.streaming'); | |||
|
|
|||
| while (length($args->{_scanbuf}) > $args->{_offset} + $args->{_need} + 8) { | |||
There was a problem hiding this comment.
Is this just an optimization, which shouldn't have any impact?...
There was a problem hiding this comment.
Kind of - using $offset is just easier to read
michaelherger
approved these changes
Apr 17, 2024
|
Yes, absolutely needs to be back ported |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for https://forums.slimdevices.com/forum/user-forums/logitech-media-server/1699393-some-aac-files-result-in-error-decoder-does-not-support-file-format-code-0#post1699393.
When mp4 files have a trailing moov atom, the stco could be missed and the audio_offset would be wrong. Fix as well the total length check that should be only done once during the first parse