Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default ignore resource pack behavior causes resource pack not reload when do /iazip #30

Open
nhanledev opened this issue Feb 3, 2023 · 2 comments
Labels
type: bug Something isn't working

Comments

@nhanledev
Copy link
Contributor

nhanledev commented Feb 3, 2023

Given this config in Waterfall

log:
  ignored_respack: true
  sent_respack: true
  debug: true
equal_pack_attributes:
  hash: true
  forced: true
  prompt_message: true
ignore_hash_in_url: true
main_spigot_server_name: server_1
ignored_servers:
  enabled: false
  invert_check: false
  list:
    - ignored_1
    - ignored_2

When I do /iazip the resource pack reload is cancelled.
Log:

[22:07:25 WARN] [BungeePackFix]: Sending pack: HibaraMamoru ClientboundResourcePackPacket{url='http://10.200.0.31:8163/generated.zip#e44ecf9719c311653dfe0cf713c790d6e2cca402', hash=null, forced=true, promptMessage={"extra":[{"text":"\n"},{"bold":false,"italic":false,"underlined":false,"strikethrough":false,"obfuscated":false,"color":"white","text":"REACTED TEXT"},{"bold":true,"italic":false,"underlined":false,"strikethrough":false,"obfuscated":false,"color":"white","text":"REACTED TEXT"},{"bold":true,"italic":false,"color":"blue","text":"MC\n\n"},{"bold":false,"italic":false,"color":"white","text":"REACTED TEXT"}],"text":""}}
[22:07:25 WARN] [BungeePackFix]: RespackStatusPacketIn: HibaraMamoru ACCEPTED
[22:07:26 WARN] [BungeePackFix]: RespackStatusPacketIn: HibaraMamoru SUCCESSFULLY_LOADED
[22:07:30 WARN] [BungeePackFix]: Ignored already sent pack: HibaraMamoru ClientboundResourcePackPacket{url='http://10.200.0.31:8163/generated.zip#e44ecf9719c311653dfe0cf713c790d6e2cca402', hash=null, forced=true, promptMessage={"extra":[{"text":"\n"},{"bold":false,"italic":false,"underlined":false,"strikethrough":false,"obfuscated":false,"color":"white","text":"REACTED TEXT"},{"bold":true,"italic":false,"underlined":false,"strikethrough":false,"obfuscated":false,"color":"white","text":"REACTED TEXT"},{"bold":true,"italic":false,"color":"blue","text":"MC\n\n"},{"bold":false,"italic":false,"color":"white","text":"REACTED TEXT"}],"text":""}

What to expected:

ignore_hash_in_url shoud be defaulted as false

@LoneDev6
Copy link
Owner

LoneDev6 commented Feb 6, 2023

Does setting ignore_hash_in_url: false fix the issue?

@LoneDev6 LoneDev6 added the type: bug Something isn't working label Feb 6, 2023
@nhanledev
Copy link
Contributor Author

ignore_hash_in_url: false fix the issue. I suggested to set it to false by default to prevent confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants