Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BungeePackFix 1.1.3 When using Minecraft 1.20.2, switching servers does not skip resource pack loading, it always reloads #44

Open
tygh89071388 opened this issue Oct 7, 2023 · 24 comments
Labels
type: bug Something isn't working type: minecraft bug Bug that only Mojang can fix. Can be both client or server bug.
Milestone

Comments

@tygh89071388
Copy link

tygh89071388 commented Oct 7, 2023

When using Minecraft 1.20.2, switching servers does not skip resource pack loading, it always reloads

Everything works fine when using 1.20.1.

This server is running Paper version git-Paper-169 (MC: 1.20.1) (Implementing API version 1.20.1-R0.1-SNAPSHOT) (Git: b4e3b3d)
This server is running Waterfall version git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:0e657ed:545 by md_5

@SrFirox
Copy link

SrFirox commented Oct 8, 2023

i have the same problem.

@LoneDev6
Copy link
Owner

LoneDev6 commented Oct 9, 2023

Check if you set ignore hash false in config.yml of BungeePackFix, it might be the reason.
The plugin was tested and working before publishing the update.

@LoneDev6 LoneDev6 added the verdict: misconfigured Some configuration files are not correctly set-up. label Oct 9, 2023
@naikyys
Copy link

naikyys commented Oct 9, 2023

Hey, its not misconfigured. Have the same issue, only 1.20.2 is still redownloading the pack, but lower versions not. Even if I set ignore hash to false in config.yml of BungeePackFix. Please fix it :/

EDIT: Setting hash to false just mess up all versions below 1.20.2. When set to true, only 1.20.2 not working.

@LoneDev6
Copy link
Owner

Can you confirm that 1.20.2 requires ignore hash to be set to false in order to avid redownloading the pack each time?

@naikyys
Copy link

naikyys commented Oct 12, 2023

Can you confirm that 1.20.2 requires ignore hash to be set to false in order to avid redownloading the pack each time?

No. You have to just fix that 1.20.2 is still redownloading and versions below 1.20.2 are fine.

@SuprexDE
Copy link

i have the same issue. When will the fix come?

@naikyys
Copy link

naikyys commented Oct 16, 2023

Is it please possible to fix it please?... As you can see, many people having the same issue.

@nhanledev
Copy link
Contributor

I created a pull request at #48 and that should fix this issue.

@LoneDev6
Copy link
Owner

It's related to a Minecraft bug which we can't fix for now.
https://bugs.mojang.com/browse/MC-265673

@LoneDev6 LoneDev6 added type: bug Something isn't working type: minecraft bug Bug that only Mojang can fix. Can be both client or server bug. and removed verdict: misconfigured Some configuration files are not correctly set-up. labels Oct 23, 2023
@Domm1
Copy link

Domm1 commented Oct 31, 2023

It got suggested to feedback.minecraft since they deem this as feature request, here is the link to vote for it.

https://feedback.minecraft.net/hc/en-us/community/posts/20698154329869-Don-t-reset-the-resource-pack-when-entering-configuration-phase

@jhqwqmc
Copy link

jhqwqmc commented Nov 20, 2023

mojang added this feature.

https://www.minecraft.net/en-us/article/minecraft-1-20-3-pre-release-1

@LoneDev6
Copy link
Owner

Did they fix the issue? Did they revert the logic or changed it again?

@jhqwqmc
Copy link

jhqwqmc commented Nov 20, 2023

Maybe changed a little logic, also restored some logic
image

@Aitooor
Copy link

Aitooor commented Dec 11, 2023

Is there any news about 1.20.2 and if Mojang's changes helped to fix the compatibility issue?

@derMiepz
Copy link

derMiepz commented Jan 3, 2024

Seems like Mojang already fixed the issue with reloading texture packs, so fixing it shouldn't be that big of a deal.

@nhanledev
Copy link
Contributor

They (Mojang) change the resource pack logic completely to other packet from 1.20.3, so Lone has to rewrite some additional codes to fix that.

@SimonMage
Copy link

I created a pull request at #48 and that should fix this issue.

@nhanledev
Could you make a fork of latest version of the plugin with your fix for 1.20.2 with a jar file. I need it a lot

@LoneDev6
Copy link
Owner

LoneDev6 commented Jan 9, 2024

1.20.2 is a bugged version and it's not planned to be added as compatibility because people should stop using it.
Use 1.20.3 instead.
1.20.3 support is added in the new Bungeepackfix update.
1.20.2 clients won't be handled by Bungeepackfix anymore so the plugins can send packs anytime, so clients should correctly see the pack sent each time they change server.

Let me know if it works on 1.20.3+
Download: https://github.com/LoneDev6/BungeePackFix/releases/tag/1.1.5-beta-1

@LoneDev6 LoneDev6 added this to the 1.1.5-beta-1 milestone Jan 9, 2024
@el211
Copy link

el211 commented Jan 12, 2024

1.20.2 is a bugged version and it's not planned to be added as compatibility because people should stop using it. Use 1.20.3 instead. 1.20.3 support is added in the new Bungeepackfix update. 1.20.2 clients won't be handled by Bungeepackfix anymore so the plugins can send packs anytime, so clients should correctly see the pack sent each time they change server.

Let me know if it works on 1.20.3+ Download: https://github.com/LoneDev6/BungeePackFix/releases/tag/1.1.5-beta-1

i got same issue... cant use 1.20.3 this will break all my custom maps....

@ttt0
Copy link

ttt0 commented Jan 15, 2024

1.20.2 is a bugged version and it's not planned to be added as compatibility because people should stop using it. Use 1.20.3 instead. 1.20.3 support is added in the new Bungeepackfix update. 1.20.2 clients won't be handled by Bungeepackfix anymore so the plugins can send packs anytime, so clients should correctly see the pack sent each time they change server.

Let me know if it works on 1.20.3+ Download: https://github.com/LoneDev6/BungeePackFix/releases/tag/1.1.5-beta-1

It does not work properly in version 1.20.4. I use Flamecord and in most of the things I do, it gives the error "disconnected with: DecoderException: io.netty.util.IllegalReferenceCountException: refCnt: ​​0, decrement: 1 @ io.netty.handler.codec.MessageToMessageDecoder:98" and throws it out of the game. It gets fixed when I delete bungeepackfix.

@victordumoulin
Copy link

Hello; i use 1.20.4 but the plugin on the bungee doesn't seem to create an error; but the texture pack reloads between servers..
Does anyone have a solution?? even a crazy one
Sans titre

@TerryLVM
Copy link

1.20.3 and 1.20.4 are working fine, but previous versions such as 1.19.4 or 1.20.1 stopped working.
It seems that you removed support for those versions because the resourcepack is sent each time they change server.

@LoneDev6
Copy link
Owner

LoneDev6 commented Jan 29, 2024

1.20.3 and 1.20.4 are working fine, but previous versions such as 1.19.4 or 1.20.1 stopped working. It seems that you removed support for those versions because the resourcepack is sent each time they change server.

I need to see your BungeePackFix settings file.

The strange thing is that I tested the plugin extensively before release and everything works as intended on my end.
The only not working version is 1.20.2 and it won't be supported as it's bugged and Mojang fixed the issue on 1.20.3.

Note for me:
LuluxClient offered beta testing help.
PluginBugs/Issues-ItemsAdder#3387 (comment)

@TerryLVM
Copy link

These are my settings:

messages:
minimessage_support: false
ignored_pack:
enabled: true
message: "&7Texturepack cargado con éxito"
equal_pack_attributes:
hash: true
forced: true
prompt_message: true
modern_uuid: true
ignore_hash_in_url: true
main_spigot_server_name: lobby1
ignored_servers:
enabled: false
invert_check: false
list:
- MULTIFFA-1
- DUELS-1
- DUELS-2
log:
ignored_respack: false
sent_respack: false
debug: false
cancel_modern_resourcepack_remove_packet: true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working type: minecraft bug Bug that only Mojang can fix. Can be both client or server bug.
Projects
None yet
Development

No branches or pull requests