Request -- Ocean tiles should not be claimable by cities

[ryanmusante]

1. Mod version (i.e Date - 4/23):
4/30

2. Mod list (if using Vox Populi only, leave blank):
Infixo's UI Mods

3. Error description:
Ocean tiles should not be claimed by cities. If units require compass for traversing ocean tiles, why can a city claim an ocean tile for work (extremely low yields)?

Problems with cities having ocean tiles:

1. Extremely low yields
2. Blocks early/mid-game travel for civs uncovering fog of war
3. Blocks mid game travel for establish sea trade routes
4. Creates deadlocks for ships at sea leading to wars otherwise unnecessary
5. Prevents artificial dead spots in between owned territories
6. Comparable to moden day Maritime Law/Admiralty Law, civs do not have so much of the ocean claimed as owned territory

FIX: Global - Coastal Waters Only Mod:

UPDATE CustomModOptions SET Value=1 WHERE Name="EVENT_CITY_BORDERS";
along with GlobalCoastalWatersOnly.lua

4. Steps to reproduce (optional):

---

Supporting information:
Please note that you can attach .zip files by dragging-and-dropping them. If possible, zip up all supporting data and post that way.

[ilteroi]

so your're proposing to include this mod or to replace it?

in general lua hooks aren't great for performance.

[ryanmusante]

I'm proposing to include the mod. According to latest version from 2016:

Cities may only acquire water plots if they are adjacent to land or contain a workable feature (atolls, et al) or visible resource (fish, whales, et al)

[Iamblichos]

If it's to be included, let's do the work in C++ and not Lua. @ilteroi is right, Lua hooks are a poor way to make a feature work.

[ryanmusante]

Indeed, cpp is the way to go, I agree. Beow is the lua script:

print("This is the 'Global - Coastal Waters Only' mod script")
--
-- This function is called whenever a city is considering a tile for acquisition.
-- It is called after the standard checks (does anybody else own this tile, etc)
--
function OnCityCanAcquirePlot(iPlayer, iCity, iPlotX, iPlotY)
  -- print(string.format("OnCityCanAcquirePlot(%d, %d - (%d, %d))", iPlayer, iCity, iPlotX, iPlotY))
  local pPlot = Map.GetPlot(iPlotX, iPlotY)
  if (pPlot:IsWater() and not pPlot:IsAdjacentToLand()) then
    -- Non-coastal water, check for features (atolls, natural wonders etc) or visible resources
	if (pPlot:GetFeatureType() == -1 and pPlot:GetResourceType(Players[iPlayer]:GetTeam()) == -1) then
	  -- print("  ... plot may NOT be acquired")
	  return false
	end
  end
  -- By default we can acquire the plot
  return true
end
GameEvents.CityCanAcquirePlot.Add(OnCityCanAcquirePlot)
GameEvents.CityCanBuyPlot.Add(OnCityCanAcquirePlot)

[ilteroi]

well, that piece of code raises a few questions:

• there is also "shallow water" which is not adjacent to land. i would include that in the definition of coastal.
• there is no check for player tech? i was assuming that after a player can cross ocean the restriction would be lifted.

[Iamblichos]

Needs to be isCoastalLand

[tu-79]

So ocean is no longer claimable ever? Or just before Compass?

[ilteroi]

before compass. or whatever the relevant tech is ...

[bigcat88]

What about Polynesia? They can claim ocean from start or like others from request tech?

[TechpriestEnginseer]

Wasn't it that you could traverse your own ocean's tiles or was that just a version later too late? That's my inquiry.

[ilteroi]

polynesia is fine. can buy/claim from the start.

the other question i don't understand

[TechpriestEnginseer]

Ships can travel ocean tiles that are owned by their cities pre-Compass.

I also feel like there should be an exception for one-tile city islands to be able to claim ocean pre-Compass...

[ilteroi]

1. i think that's obsolete with the may-traverse-ocean-but-cannot-end-turn-there rule.
2. how would you settle those one-tile islands?

[ryanmusante]

#6555