Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player:GetHistoricEventTourism(iHistoricEvents, pCity) and Player:GetNumHistoricEventTourism(iHistoricEvents) #9908

Closed
TechpriestEnginseer opened this issue May 30, 2023 · 3 comments

Comments

@TechpriestEnginseer
Copy link
Collaborator

TechpriestEnginseer commented May 30, 2023

  • 0 | HISTORIC_EVENT_ERA_CHANGE | Player
  • 1 | HISTORIC_EVENT_WORLD_WONDER | Player
  • 2 | HISTORIC_EVENT_GREAT_PERSON | Player
  • 3 | HISTORIC_EVENT_WON_WAR | Player
  • 4 | HISTORIC_EVENT_GOLDEN_AGE | Player
  • 5 | HISTORIC_EVENT_DIG | Player
  • 6 | HISTORIC_EVENT_TRADE_LAND | requires City
  • 7 | HISTORIC_EVENT_TRADE_SEA | requires City
  • 8 | HISTORIC_EVENT_TRADE_CS | Player (Surprisingly, City does not affect them)

I can definitely wiggle some room in Culture Overview to talk about how Historic Events and their (most potential) yields if they achieve them. It would also be nice to get GetNumHistoricEventTourism since that is already given to us (for Arabia) and can help show us how many Historic Events of this type have been achieved for the selected player.
image

Of course when it comes to the land trade and sea trade, I can put in (Parenthesis) Like +300 (+100) to indicate that it has a weaker tourism boost with all known Civilizations versus the one you are trading with actively.

@azum4roll
Copy link
Collaborator

How would you show the trade route ones when they differ between cities?

@TechpriestEnginseer
Copy link
Collaborator Author

We have a scroll bar.

It would just be
{EverythingElse}
...
{1_CityName} [ICON_CARAVAN]
{1_CityName} [ICON_CARGO_SHIP]
{2_CityName} [ICON_CARAVAN]
{2_CityName} [ICON_CARGO_SHIP]
OR...
It takes the highest Tourism boost and indicates the City.
The only thing the DLL currently can't record now is the number of times the Historic Event happens in a city, but I don't think that's too important if we're trying to save on memory. So it will only count the # of times a Historic Event of this type has occurred. The past event counter is just a cool thing to have for information addicts but no big deal to try to create new memory over.

@jarcast
Copy link
Contributor

jarcast commented Jun 1, 2023

To complete the picture it would also be nice for modding purposes to have a related hook game event for when a historic event is triggered or completed. For example:

HistoricEventTriggered(PlayerID iPlayer, CityID iCity, HistoricEventType iHistoricEvent)

HistoricEventCompleted(PlayerID iPlayer, CityID iCity, HistoricEventType iHistoricEvent)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants