Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsafe variable declaration in bootstrap_helper.sh #4917

Closed
klikevil opened this issue Jun 23, 2022 · 0 comments
Closed

Unsafe variable declaration in bootstrap_helper.sh #4917

klikevil opened this issue Jun 23, 2022 · 0 comments

Comments

@klikevil
Copy link

klikevil commented Jun 23, 2022 •
edited

Decentralized-Internet/clusterpost/bigchaindb/pkg/scripts/bootstrap_helper.sh

Line 7 in 82351a8

BASEDIR="${BASH_SOURCE%/*}"

When invoked with:
bash bootstrap_helper.sh (from the same directory as the script)

${BASH_SOURCE%/*} would return:
bootstrap_helper.sh

This would probably be better written as:
BASEDIR="$(dirname $(readlink -f $0))"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Mentors4EDU @klikevil